Add BLOCK_POSITION_NOT_NULL argument convention #18035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
delta-lake
dain
force-pushed
the
not-null-block-position
branch
3 times, most recently
from
45fdc84 to
b5e7378
Compare
dain
changed the title
dain
force-pushed
the
not-null-block-position
branch
2 times, most recently
from
398e404 to
0f625a3
Compare
electrum
approved these changes
Jun 28, 2023
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/test/java/io/trino/spi/function/TestScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/PolymorphicScalarFunctionBuilder.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/ChoicesSpecializedSqlScalarFunction.java
Show resolved
Hide resolved
...-main/src/main/java/io/trino/operator/scalar/annotations/ParametricScalarImplementation.java
Show resolved
Hide resolved
| @@ -166,6 +166,7 @@ synchronized void buildHashTableStrict(Block keyBlock, int keyOffset, int keyCou | |||
| int hashTableSize = keyCount * HASH_MULTIPLIER; | |||
|
|
|||
| for (int i = 0; i < keyCount; i++) { | |||
| // this throws if the position is null | |||
There was a problem hiding this comment.
Maybe split out the map and row type changes, since they're more substantial
There was a problem hiding this comment.
I split out the map change, but the row changes are pretty simple
core/trino-spi/src/main/java/io/trino/spi/type/TypeOperatorDeclaration.java
Show resolved
Hide resolved
dain
force-pushed
the
not-null-block-position
branch
from
0f625a3 to
810b6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When function are declared with the
@BlockPositionargument convention the argument is not nullable unless the@SqlNullableis also present, but when calling a function with theBLOCK_POSITIONthe system checks if the position is null. This check is not needed in most cases, because the caller already handles nulls explicitly. The PR adds a new calling conventionBLOCK_POSITION_NOT_NULLwhich tells the function system that the caller will not call the function with a null position, which allows for more efficient function calls.Additionally, the internal
@NullablePositionannotation has been replaced with the existing@SqlNullableSPI annotation.Release notes
(X) Release notes are required, with the following suggested text: