Increase domain compaction limits for hive and delta #18024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
delta-lake
Dith3r
approved these changes
Jun 23, 2023
raunaqmorarka
force-pushed
the
increase-domain
branch
from
490623f to
cbb893f
Compare
|
please run benchmarks if 1000 doesn't cause regressions (I think it does). |
|
Increased domain threshold sf1k unpartitioned parquet.pdf Added benchmark, it shows CPU increases in some places and decreases in other places. The differences are within the usual window of variability in results. I checked JFR profile for query with highest difference and there is nothing related to tuple domains in it. |
sopel39
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase domain compaction limits for hive and delta.
Makes the default limit consistent with iceberg.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: