Round targetPartitionSizeInBytes to a multiple of minTargetPartitionSizeInBytes #17834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzebing
force-pushed
the
adaptive-sizing-round-correction
branch
from
20b41a0 to
858650d
Compare
losipiuk
reviewed
Jun 12, 2023
...-main/src/test/java/io/trino/execution/scheduler/TestArbitraryDistributionSplitAssigner.java
Show resolved
Hide resolved
losipiuk
reviewed
Jun 12, 2023
...rino-main/src/main/java/io/trino/execution/scheduler/ArbitraryDistributionSplitAssigner.java
Show resolved
Hide resolved
linzebing
force-pushed
the
adaptive-sizing-round-correction
branch
from
858650d to
00503eb
Compare
losipiuk
approved these changes
Jun 13, 2023
losipiuk
pushed a commit
to linzebing/trino
that referenced
this pull request
Jul 6, 2023
After trinodb#17834, 1.26 becomes the better default.
losipiuk
pushed a commit
that referenced
this pull request
Jul 6, 2023
After #17834, 1.26 becomes the better default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With growth factor 1.2:
sequence: 512MB, 614.4MB, 737.28MB, 884.736MB, 1061.6832MB
Previous: 512MB, 1024MB, 1536MB, 2048MB, 2560MB
With the change: 512MB, 512MB, 512MB, 1024MB, 1024MB
With some adjustments, sf1000 stays mostly unchanged, sf100 improved wall time around 3.6%
Additional context and related issues
4561f0c
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: