Iceberg connector copy edits and format improvements #17730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Jun 1, 2023
There was a problem hiding this comment.
This looks good. Please keep these separate commits and do not squash. But update each commit message to mention the Iceberg connector documentation. And we have to keep the message shortish...
So maybe:
- Adjust source code formatting in Iceberg docs
- Fix formatting of Nessie table in Iceberg docs
- Copy edit of Iceberg connector documentation
|
All edits look good as well. Please adjust commits and address the one needed change .. then I can approve and merge. |
mosabua
reviewed
Jun 1, 2023
m57lyra
reviewed
Jun 1, 2023
tlblessing
force-pushed
the
tb/doc-6024
branch
2 times, most recently
from
c974c88 to
bebbf23
Compare
colebow
approved these changes
Jun 2, 2023
m57lyra
approved these changes
Jun 2, 2023
Annie feedback
mosabua
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iceberg connector copy edits and format improvements