Fix incorrect @BeforeTest usages #17650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
ksobolew
approved these changes
May 26, 2023
In some places before-test-method and in some before-class was apparently meant. `TestReportPrivateMethods`is changed too to limit proliferation of this annotation. TestNG method invocation order example ``` Test class 1: @BeforeTest Test class 2: @BeforeTest Test class 1: @BeforeCass Test class 1: @BeforeMethod Test class 1: a test 1 Test class 1: @AfterMethod Test class 1: @BeforeMethod Test class 1: a test 2 Test class 1: @AfterMethod Test class 1: @afterclass Test class 2: @BeforeCass Test class 2: @BeforeMethod Test class 2: a test 1 Test class 2: @AfterMethod Test class 2: @BeforeMethod Test class 2: a test 2 Test class 2: @AfterMethod Test class 2: @afterclass Test class 1: @AfterTest Test class 2: @AfterTest ```
findepi
force-pushed
the
findepi/fix-incorrect-beforetest-usages-b738b3
branch
from
e6595db to
388b246
Compare
|
Should we ban usages of |
kokosing
approved these changes
May 26, 2023
|
@kokosing good idea |
|
CI #16277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places before-test-method and in some before-class was apparently meant.
TestReportPrivateMethodsis changed too to limit proliferation of this annotation.TestNG method invocation order example