Refactor BaseConnectorTest#testComment* to reduce queries #17633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
May 25, 2023
wendigo
approved these changes
May 25, 2023
ebyhr
approved these changes
May 25, 2023
ebyhr
reviewed
May 25, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/comment-tests
branch
from
e270085 to
b68e65d
Compare
See the change in previous commit.
hashhar
force-pushed
the
hashhar/comment-tests
branch
from
b68e65d to
73eb4bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps with BigQuery for example since number of metadata operations per second is limited.
Other tests also benefit with being slightly faster.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.