Delta lake tests improvements #17622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
findepi
changed the title
findepi
force-pushed
the
findepi/randomize-bucket-name-in-delta-tests-a443de
branch
2 times, most recently
from
f7a2850 to
73db6a7
Compare
github-actions
bot
added
delta-lake
findepi
force-pushed
the
findepi/randomize-bucket-name-in-delta-tests-a443de
branch
from
73db6a7 to
bb0ac7b
Compare
findepi
commented
May 24, 2023
| @@ -1759,7 +1760,7 @@ protected OptionalInt maxTableNameLength() | |||
| @Override | |||
| protected void verifyTableNameLengthFailurePermissible(Throwable e) | |||
| { | |||
| assertThat(e).hasMessageMatching("(?s)(.*Read timed out)|(.*\"`TBL_NAME`\" that has maximum length of 128.*)"); | |||
| assertThat(e).hasMessageMatching("Table name must be shorter than or equal to '128' characters but got.*"); | |||
There was a problem hiding this comment.
it looks like we're losing test coverage for proper handling of too long names, but in fact we didn't have it before, as "read timed out" was an allowed outcome. thus it's not a big loss.
we should, however, test name limits on the smoke test, since that's what is run against different metastores/catalogs in delta & iceberg.
alexjo2144
approved these changes
May 24, 2023
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/randomize-bucket-name-in-delta-tests-a443de
branch
from
bb0ac7b to
fb1cfcb
Compare
losipiuk
approved these changes
May 24, 2023
ebyhr
approved these changes
May 24, 2023
findepi
force-pushed
the
findepi/randomize-bucket-name-in-delta-tests-a443de
branch
from
fb1cfcb to
232b6ff
Compare
The test did not use HDFS anyway, only HMS, but metastore is irrelevant for this test.
The test did not use HDFS anyway, only HMS. HMS test coverage is provided by a smoke test. This makes this test easier to run on Apple M1.
findepi
force-pushed
the
findepi/randomize-bucket-name-in-delta-tests-a443de
branch
from
232b6ff to
3f9199b
Compare
|
(rebased to resolve conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.