Use Location API for path concatenation when cleaning extra output files after DML in Delta #17560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
May 23, 2023
findepi
reviewed
May 23, 2023
| @@ -2774,7 +2770,11 @@ private void cleanExtraOutputFiles(ConnectorSession session, String queryId, Loc | |||
| FileIterator iterator = fileSystem.listFiles(location); | |||
| while (iterator.hasNext()) { | |||
| Location file = iterator.next().location(); | |||
| if (isFileCreatedByQuery(file, queryId) && !filesToKeep.contains(file.toString())) { | |||
| if (!file.parentDirectory().equals(location)) { | |||
There was a problem hiding this comment.
This is not the only place with such logic.
Looks like file system could have consistent logic for listing files non-recuirsively.
There was a problem hiding this comment.
Agreed.
@electrum I assume it was a conscious decision to just have recursive file listing in new file system interface?
Can you shed some light on that - especially are there any hard reasons not to extend the API?
There was a problem hiding this comment.
Even sth like this maybe? https://github.com/trinodb/trino/pull/17608/files (#17608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: