Add projection pushdown tests in BaseConnectorTest #17414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bigquery
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
4f48af6 to
7de631f
Compare
krvikash
changed the title
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
7de631f to
d4d404a
Compare
ebyhr
reviewed
May 12, 2023
testing/trino-testing/src/main/java/io/trino/testing/TestingConnectorBehavior.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 12, 2023
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
d4d404a to
e5b51fe
Compare
|
rebased and resolved conflicts. |
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
e5b51fe to
92afbbe
Compare
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
92afbbe to
464a969
Compare
|
Addressed comments |
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
464a969 to
6e7bc18
Compare
findepi
approved these changes
May 24, 2023
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/tpch/TestTpchConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-accumulo/src/test/java/io/trino/plugin/accumulo/TestAccumuloConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/test/java/io/trino/plugin/redis/BaseRedisConnectorTest.java
Outdated
Show resolved
Hide resolved
| @@ -39,6 +39,7 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior) | |||
| return false; | |||
|
|
|||
| case SUPPORTS_TOPN_PUSHDOWN: | |||
| case SUPPORTS_DEREFERENCE_PUSHDOWN: | |||
There was a problem hiding this comment.
is row type supported for thrift?
findepi
reviewed
May 24, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
6e7bc18 to
6dbb608
Compare
krvikash
added
the
no-release-notes
ebyhr
approved these changes
May 28, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
|
/test-with-secrets sha=6dbb608c934e3b94544965dc70d51697032fab24 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5106981345 |
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
6dbb608 to
703ca68
Compare
|
Addressed comments |
krvikash
force-pushed
the
move-projection-pushdown-tests
branch
from
703ca68 to
ff7c367
Compare
|
rebased with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #17085 (comment)