Skip to content

Support table comment for redshift connector #17372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Support table comment for redshift connector #17372

merged 1 commit into from
Jul 3, 2023

Conversation

sahoss
Copy link
Contributor

@sahoss sahoss commented May 6, 2023 •
edited by ebyhr
Loading

Description

Fix #16900

Release notes

(x) Release notes are required, with the following suggested text:

# Redshift
* Add support for creating a table with a table comment. ({issue}`16900`)
* Add support for [`COMMENT ON TABLE`](/sql/comment). ({issue}`16900`)

@cla-bot cla-bot bot added the cla-signed label May 6, 2023
@sahoss sahoss marked this pull request as ready for review May 6, 2023 08:50
@sahoss
Copy link
Contributor Author

sahoss commented May 6, 2023

@chenjian2664 can you please take a look at this change request?

ebyhr
ebyhr reviewed May 7, 2023
View reviewed changes
@sahoss
Copy link
Contributor Author

sahoss commented May 17, 2023

was having a busy week. i ll address the comments in this weekend. thanks for your reviews

@sahoss sahoss closed this Jun 23, 2023
@sahoss sahoss reopened this Jun 23, 2023
@sahoss
Copy link
Contributor Author

sahoss commented Jun 24, 2023

@ebyhr @chenjian2664 do take a look here. the comments are addressed.

@sahoss sahoss requested review from ebyhr and chenjian2664 June 24, 2023 05:29
@sahoss
Copy link
Contributor Author

sahoss commented Jul 3, 2023

@ebyhr @chenjian2664 wondering if you could take a look at this pr?

@ebyhr ebyhr mentioned this pull request Jul 3, 2023
Closed
@ebyhr
Copy link
Member

ebyhr commented Jul 3, 2023

Running CI with secrets at #18112

@ebyhr ebyhr merged commit 863f386 into trinodb:master Jul 3, 2023
@github-actions github-actions bot added this to the 421 milestone Jul 3, 2023
@colebow colebow mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@chenjian2664 chenjian2664 Awaiting requested review from chenjian2664

Assignees

@sahoss sahoss

Labels
cla-signed
Milestone
421
Development

Successfully merging this pull request may close these issues.

Support table comment in Redshift
3 participants
@sahoss @ebyhr @chenjian2664