Support check constraints for UPDATE statement in engine and Delta Lake connector #17195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
a16efff to
02df7bc
Compare
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
2 times, most recently
from
1679e2e to
742c953
Compare
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
742c953 to
4b5a7d3
Compare
martint
requested changes
May 1, 2023
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
4b5a7d3 to
77866d9
Compare
pajaks
reviewed
May 10, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
77866d9 to
a69964f
Compare
|
Rebased on master to resolve conflicts. |
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
a69964f to
7fd9f56
Compare
martint
reviewed
Jun 19, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
7fd9f56 to
fbd3b1a
Compare
martint
reviewed
Jun 28, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
It causes duplicated constraints for UPDATE statement.
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
2 times, most recently
from
3f8c027 to
4682313
Compare
martint
reviewed
Jul 3, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCheckConstraintCompatibility.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
4682313 to
09162ab
Compare
|
@martint Addressed comments. |
ebyhr
force-pushed
the
ebi/core-update-check-constraints
branch
from
09162ab to
8f5d136
Compare
martint
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support check constraints for UPDATE statement in engine and Delta Lake connector
Release notes
(x) Release notes are required, with the following suggested text: