Support CREATE OR REPLACE in parser
#17050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Add a check (perhaps in |
findepi
approved these changes
Apr 19, 2023
ebyhr
approved these changes
Apr 19, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTableAsSelect.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
kasiafi
reviewed
Apr 19, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTableAsSelect.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
4 times, most recently
from
8022b17 to
886f2ce
Compare
|
PTAL, I processed all remarks. I also added checks in |
kasiafi
reviewed
Apr 25, 2023
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTableAsSelect.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
3 times, most recently
from
2daf3eb to
6feb724
Compare
kasiafi
approved these changes
Apr 28, 2023
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
from
6feb724 to
3c645c3
Compare
kasiafi
approved these changes
Apr 28, 2023
martint
requested changes
Apr 28, 2023
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
from
3c645c3 to
233a660
Compare
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
3 times, most recently
from
0b6ffe3 to
7451c53
Compare
kasiafi
reviewed
May 10, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
kasiafi
reviewed
May 10, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/SaveMode.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
from
7451c53 to
820dded
Compare
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
2 times, most recently
from
60bb642 to
7900ed4
Compare
kasiafi
reviewed
May 30, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/CreateTable.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestCreateTableTask.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
2 times, most recently
from
f9cfe96 to
cb96e14
Compare
|
@kasiafi: PTAL, I treated all comments. |
|
Create or replace is a nice feature for external systems integrating with Trino (DBT/Airbyte/etc). Any movement on the parser changes? |
kasiafi
approved these changes
Jun 15, 2023
|
@martint : Can you have a look again? |
martint
reviewed
Jun 15, 2023
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
|
@mdesmet This looks very close, can we push this over the finish line? |
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
from
cb96e14 to
a920ff4
Compare
|
@martint : I took care of the comments. Can you PTAL? |
martint
reviewed
Jul 5, 2023
core/trino-parser/src/main/java/io/trino/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
mdesmet
force-pushed
the
feature/create-or-replace-grammar
branch
from
a920ff4 to
be29a60
Compare
|
@martint : comments treated. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grammar changes to support CREATE OR REPLACE
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: