Skip to content

Populate stats when missing in transaction log #16743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ private List<DeltaLakeSplit> splitsForFile(
return splits.build();
}

private static Location buildSplitPath(Location tableLocation, AddFileEntry addAction)
public static Location buildSplitPath(Location tableLocation, AddFileEntry addAction)
{
// paths are relative to the table location and are RFC 2396 URIs
// https://github.com/delta-io/delta/blob/master/PROTOCOL.md#add-file-and-remove-file
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.trino.plugin.deltalake.transactionlog;

import io.trino.plugin.deltalake.DeltaLakeColumnHandle;
import io.trino.plugin.deltalake.transactionlog.statistics.DeltaLakeJsonFileStatistics;
import io.trino.spi.block.Block;
import io.trino.spi.statistics.ColumnStatisticMetadata;
import io.trino.spi.statistics.ColumnStatisticType;
import io.trino.spi.statistics.ComputedStatistics;
import io.trino.spi.type.Type;

import java.util.Map;
import java.util.Optional;
import java.util.OptionalLong;

import static com.google.common.collect.ImmutableMap.toImmutableMap;
import static io.trino.plugin.deltalake.transactionlog.DeltaLakeParquetStatisticsUtils.toJsonValue;
import static io.trino.spi.statistics.ColumnStatisticType.MAX_VALUE;
import static io.trino.spi.statistics.ColumnStatisticType.MIN_VALUE;
import static io.trino.spi.statistics.ColumnStatisticType.NUMBER_OF_NON_NULL_VALUES;
import static io.trino.spi.statistics.TableStatisticType.ROW_COUNT;
import static io.trino.spi.type.BooleanType.BOOLEAN;
import static io.trino.spi.type.TypeUtils.readNativeValue;
import static io.trino.spi.type.VarbinaryType.VARBINARY;

public final class DeltaLakeComputedStatistics
{
private DeltaLakeComputedStatistics() {}

public static DeltaLakeJsonFileStatistics toDeltaLakeJsonFileStatistics(ComputedStatistics stats, Map</* lowercase */ String, DeltaLakeColumnHandle> lowercaseToColumnsHandles)
{
Optional<Long> rowCount = getLongValue(stats.getTableStatistics().get(ROW_COUNT)).stream().boxed().findFirst();

Optional<Map<String, Object>> minValues = Optional.of(getColumnStatistics(stats, MIN_VALUE, lowercaseToColumnsHandles));
Optional<Map<String, Object>> maxValues = Optional.of(getColumnStatistics(stats, MAX_VALUE, lowercaseToColumnsHandles));

Optional<Map<String, Object>> nullCount = Optional.empty();
if (rowCount.isPresent()) {
nullCount = Optional.of(getNullCount(stats, rowCount.get(), lowercaseToColumnsHandles));
}

return new DeltaLakeJsonFileStatistics(rowCount, minValues, maxValues, nullCount);
}

private static Map<String, Object> getNullCount(ComputedStatistics statistics, long rowCount, Map</* lowercase */ String, DeltaLakeColumnHandle> lowercaseToColumnsHandles)
{
return statistics.getColumnStatistics().entrySet().stream()
.filter(stats -> stats.getKey().getStatisticType() == NUMBER_OF_NON_NULL_VALUES
&& lowercaseToColumnsHandles.containsKey(stats.getKey().getColumnName()))
.map(stats -> Map.entry(lowercaseToColumnsHandles.get(stats.getKey().getColumnName()).getBasePhysicalColumnName(), getLongValue(stats.getValue())))
.filter(stats -> stats.getValue().isPresent())
.map(nonNullCount -> Map.entry(nonNullCount.getKey(), rowCount - nonNullCount.getValue().getAsLong()))
.collect(toImmutableMap(Map.Entry::getKey, Map.Entry::getValue));
}

private static Map<String, Object> getColumnStatistics(ComputedStatistics statistics, ColumnStatisticType statisticType, Map</* lowercase */ String, DeltaLakeColumnHandle> lowercaseToColumnsHandles)
{
return statistics.getColumnStatistics().entrySet().stream()
.filter(stats -> stats.getKey().getStatisticType().equals(statisticType)
&& lowercaseToColumnsHandles.containsKey(stats.getKey().getColumnName()))
.map(stats -> mapSingleStatisticsValueToJsonRepresentation(stats, lowercaseToColumnsHandles))
.filter(Optional::isPresent)
.flatMap(Optional::stream)
.collect(toImmutableMap(Map.Entry::getKey, Map.Entry::getValue));
}

private static Optional<Map.Entry<String, Object>> mapSingleStatisticsValueToJsonRepresentation(Map.Entry<ColumnStatisticMetadata, Block> statistics, Map</* lowercase */ String, DeltaLakeColumnHandle> lowercaseToColumnsHandles)
{
Type columnType = lowercaseToColumnsHandles.get(statistics.getKey().getColumnName()).getBasePhysicalType();
String physicalName = lowercaseToColumnsHandles.get(statistics.getKey().getColumnName()).getBasePhysicalColumnName();
if (columnType.equals(BOOLEAN) || columnType.equals(VARBINARY)) {
return Optional.empty();
}

Object value = readNativeValue(columnType, statistics.getValue(), 0);
Object jsonValue = toJsonValue(columnType, value);
if (jsonValue != null) {
return Optional.of(Map.entry(physicalName, jsonValue));
}
return Optional.empty();
}

private static OptionalLong getLongValue(Block block)
{
if (block == null || block.isNull(0)) {
return OptionalLong.empty();
}
return OptionalLong.of(block.getLong(0, 0));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public static Map<String, Object> toJsonValues(Map<String, Type> columnTypeMappi
}

@Nullable
private static Object toJsonValue(Type type, @Nullable Object value)
public static Object toJsonValue(Type type, @Nullable Object value)
{
if (value == null) {
return null;
Expand Down
Loading