Skip to content

Remove Iceberg connector tests for REST and JDBC catalogs #16588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

Remove Iceberg connector tests for REST and JDBC catalogs #16588

merged 1 commit into from
Mar 16, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 16, 2023

Like for Glue, we have connector smoke tests for these.

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Mar 16, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 16, 2023
@findepi
Copy link
Member Author

findepi commented Mar 16, 2023

cc @danielcweeks @nastra @jackye1995

@findepi
Copy link
Member Author

findepi commented Mar 16, 2023

@ebyhr will this allow us to remove additional-catalog-tests profile?

@github-actions github-actions bot added the iceberg Iceberg connector label Mar 16, 2023
@findepi
Copy link
Member Author

findepi commented Mar 16, 2023

test (plugin/trino-iceberg, additional-catalog-tests) > Maven Tests

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:16 min

i will remove additional-catalog-tests profile

@findepi
Remove Iceberg connector tests for REST and JDBC catalogs
8d70a16 
Like for Glue, we have connector *smoke* tests for these.

This also removes `additional-catalog-tests` profile, as the remaining
tests are short enough not to warrant a separate profile on the CI
(below 2:30 minutes).
@findepi findepi force-pushed the findepi/remove-iceberg-connector-tests-for-rest-and-jdbc-catalogs-75420b branch from 74ff594 to 8d70a16 Compare March 16, 2023 14:31
alexjo2144
alexjo2144 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A smoke test per catalog implementation seems reasonable to me 👍

@findepi findepi merged commit 90d6f07 into trinodb:master Mar 16, 2023
@findepi findepi deleted the findepi/remove-iceberg-connector-tests-for-rest-and-jdbc-catalogs-75420b branch March 16, 2023 21:30
@github-actions github-actions bot added this to the 411 milestone Mar 16, 2023
@electrum electrum mentioned this pull request Mar 28, 2023
Merged
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
@ebyhr ebyhr mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@alexjo2144 alexjo2144 alexjo2144 approved these changes

@electrum electrum Awaiting requested review from electrum

@findinpath findinpath Awaiting requested review from findinpath

Assignees
No one assigned
Labels
cla-signed iceberg Iceberg connector no-release-notes This pull request does not require release notes entry test
Milestone
411
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @ebyhr @alexjo2144