-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Support INSERT in Google Sheets connector #15026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support INSERT in Google Sheets connector #15026
Conversation
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsPageSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsRecordCursor.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
.../trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsPageSinkProvider.java
Outdated
Show resolved
Hide resolved
...trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsOutputTableHandle.java
Outdated
Show resolved
Hide resolved
Please separate a commit into INSERT and type mapping. |
e30efd7
to
088ccb7
Compare
@ebyhr thanks for your fast and extensive review! All feedback should be adressed |
ae699d9
to
e73f7fc
Compare
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
10942a6
to
48aadfa
Compare
@ebyhr many thanks again! Feedback should be addressed |
e98b8a8
to
2887cfa
Compare
2887cfa
to
eb22752
Compare
Rebased and fixed all the introduced conflicts. I'm going to look into creating a dedicated spreadsheet for every test invocation. |
eb22752
to
1eec3fe
Compare
I refactored all the Google sheet tests to:
|
1eec3fe
to
374e319
Compare
374e319
to
2c43486
Compare
Rebased to master. @ebyhr it would be really great if you could review this please |
Can we extract a PR for the 2nd commit? I'm not convinced the internal format of a new type mapping. |
Please rebase on master to resolve conflicts. |
@sbernauer Congrats on this PR. Do you think it is going to be merged anytime soon? Sorry to bother; it's just that it is critical for us. We'd give a hand with the code but we are Python, not Java, experts, and we aren't familiar enough with Trino internals. |
@glarrain-cdd Which feature (INSERT or type mapping) is critical for you? |
INSERT! Thank you very much |
2c43486
to
0d14fb6
Compare
Hi @glarrain-cdd and @ebyhr, sorry for the slow response time. The customer I started implementing this dropped the requirement for this feature. Nevertheless I would like to get it in, just for the community purpose. I did rework my entire PR (there were some changes regarding the TableHandle in the meantime). Additionally I dropped the whole type mapping thing, so that we can focus entirely on the INSERTs. One open point is enabling Google Drive API access for the Google serviceuser the Trino project uses, so that we can clean up the Spreadsheets we create in the test run. I can't do that, some maintainer needs to do that. All the best, |
0d14fb6
to
c4aae16
Compare
Rebased and fixed conflicts. |
c4aae16
to
030e199
Compare
030e199
to
efc1ee9
Compare
efe7a20
to
d942f2c
Compare
@mosabua thanks for the docs review! Addressed your comments |
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsPageSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
d942f2c
to
5e12b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kokosing thanks for your review! Feedback should be addressed
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsPageSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% comments
plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
Outdated
Show resolved
Hide resolved
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsClient.java
Outdated
Show resolved
Hide resolved
5e12b0a
to
0da69b2
Compare
@kokosing thanks again, feedback adressed |
Thank you. Merged. I am sorry for any delays you have experienced. This is really nice contribution. |
Thanks for the quick review after posting on Slack! |
Description
Fixes #3866. Extracted parts out of #5011
This PR add support for
INSERT
statements in the Google Sheets connectorNon-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: