Implement dereference pushdown for MongoDB connector #14467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
findepi,
ebyhr,
phd3,
kokosing,
s2lomon and
skrzypo987
skrzypo987
reviewed
Oct 6, 2022
| @@ -29,28 +33,51 @@ | |||
| public class MongoColumnHandle | |||
| implements ColumnHandle | |||
| { | |||
| private final String name; | |||
| private final String baseName; | |||
There was a problem hiding this comment.
nit: you can make a record out of it in a separate commit. That way there will be more deleted lines of code and some reviewers(me) will more likely approve because of that.
|
|
||
| MongoTableHandle mongoTableHandle = (MongoTableHandle) handle; | ||
|
|
||
| // all references are simple variables |
There was a problem hiding this comment.
nit: According to clean code rules you should extract a boolean variable with a meaningful name and get rid of the comment.
| @@ -29,28 +33,51 @@ | |||
| public class MongoColumnHandle | |||
| implements ColumnHandle | |||
| { | |||
| private final String name; | |||
| private final String baseName; | |||
There was a problem hiding this comment.
nit: Changing name to baseName in a separate commit would be easier to review. It can be squashed before the merge if you like
| try (TestTable table = new TestTable( | ||
| new TrinoSqlExecutor(getQueryRunner()), | ||
| "projection_pushdown", | ||
| format("(col_0 row(col_1 %1$s, col_2 row(col_3 %1$s, col_4 row(col_5 %1$s))))", expectedType))) { |
There was a problem hiding this comment.
Add some dummy irrelevant column in the middle to see if it will be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3765
Non-technical explanation
Improve performance for queries on nested data through dereference pushdown.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: