Improve SetDigest serialization

trinodb · Jan 7, 2025 · 917f687 · 917f687
1 parent 9e0ff60
commit 917f687
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/client/trino-client/src/main/java/io/trino/client/ClientStandardTypes.java b/client/trino-client/src/main/java/io/trino/client/ClientStandardTypes.java
@@ -28,6 +28,7 @@ public final class ClientStandardTypes
     public static final String HYPER_LOG_LOG = "HyperLogLog";
     public static final String QDIGEST = "qdigest";
     public static final String TDIGEST = "tdigest";
+    public static final String SET_DIGEST = "SetDigest";
     public static final String P4_HYPER_LOG_LOG = "P4HyperLogLog";
     public static final String INTERVAL_DAY_TO_SECOND = "interval day to second";
     public static final String INTERVAL_YEAR_TO_MONTH = "interval year to month";

diff --git a/client/trino-client/src/main/java/io/trino/client/JsonDecodingUtils.java b/client/trino-client/src/main/java/io/trino/client/JsonDecodingUtils.java
@@ -51,6 +51,7 @@
 import static io.trino.client.ClientStandardTypes.QDIGEST;
 import static io.trino.client.ClientStandardTypes.REAL;
 import static io.trino.client.ClientStandardTypes.ROW;
+import static io.trino.client.ClientStandardTypes.SET_DIGEST;
 import static io.trino.client.ClientStandardTypes.SMALLINT;
 import static io.trino.client.ClientStandardTypes.SPHERICAL_GEOGRAPHY;
 import static io.trino.client.ClientStandardTypes.TIME;
@@ -142,6 +143,7 @@ private static TypeDecoder createTypeDecoder(ClientTypeSignature signature)
             case QDIGEST:
             case P4_HYPER_LOG_LOG:
             case HYPER_LOG_LOG:
+            case SET_DIGEST:
             case VARBINARY:
             default:
                 return BASE_64_DECODER;

diff --git a/core/trino-main/src/main/java/io/trino/type/setdigest/SetDigestType.java b/core/trino-main/src/main/java/io/trino/type/setdigest/SetDigestType.java
@@ -22,6 +22,7 @@
 import io.trino.spi.connector.ConnectorSession;
 import io.trino.spi.type.AbstractVariableWidthType;
 import io.trino.spi.type.SqlVarbinary;
+import io.trino.spi.type.StandardTypes;
 import io.trino.spi.type.TypeSignature;
 
 // Layout is <size>:<digest>, where
@@ -31,7 +32,7 @@ public class SetDigestType
         extends AbstractVariableWidthType
 {
     public static final SetDigestType SET_DIGEST = new SetDigestType();
-    public static final String NAME = "SetDigest";
+    public static final String NAME = StandardTypes.SET_DIGEST;
 
     private SetDigestType()
     {

diff --git a/core/trino-spi/src/main/java/io/trino/spi/type/StandardTypes.java b/core/trino-spi/src/main/java/io/trino/spi/type/StandardTypes.java
@@ -28,6 +28,7 @@ public final class StandardTypes
     public static final String HYPER_LOG_LOG = "HyperLogLog";
     public static final String QDIGEST = "qdigest";
     public static final String TDIGEST = "tdigest";
+    public static final String SET_DIGEST = "SetDigest";
     public static final String P4_HYPER_LOG_LOG = "P4HyperLogLog";
     public static final String INTERVAL_DAY_TO_SECOND = "interval day to second";
     public static final String INTERVAL_YEAR_TO_MONTH = "interval year to month";