Skip to content

Commit 6cb2bda

Browse files
linzebinglosipiuk
authored andcommitted
Change adaptive query execution growth factor to be 1.26
After #17834, 1.26 becomes the better default.
1 parent f022816 commit 6cb2bda

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@ public class QueryManagerConfig
111111
private int remoteTaskGuaranteedSplitPerTask = 3;
112112

113113
private int faultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthPeriod = 64;
114-
private double faultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthFactor = 1.2;
114+
private double faultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthFactor = 1.26;
115115
private DataSize faultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeMin = DataSize.of(512, MEGABYTE);
116116
private DataSize faultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeMax = DataSize.of(50, GIGABYTE);
117117

118118
private int faultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthPeriod = 64;
119-
private double faultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthFactor = 1.2;
119+
private double faultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthFactor = 1.26;
120120
private DataSize faultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeMin = DataSize.of(4, GIGABYTE);
121121
private DataSize faultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeMax = DataSize.of(50, GIGABYTE);
122122

core/trino-main/src/test/java/io/trino/execution/TestQueryManagerConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ public void testDefaults()
8080
.setRemoteTaskRequestSizeHeadroom(DataSize.of(2, DataSize.Unit.MEGABYTE))
8181
.setRemoteTaskGuaranteedSplitPerTask(3)
8282
.setFaultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthPeriod(64)
83-
.setFaultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthFactor(1.2)
83+
.setFaultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeGrowthFactor(1.26)
8484
.setFaultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeMin(DataSize.of(512, MEGABYTE))
8585
.setFaultTolerantExecutionArbitraryDistributionComputeTaskTargetSizeMax(DataSize.of(50, GIGABYTE))
8686
.setFaultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthPeriod(64)
87-
.setFaultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthFactor(1.2)
87+
.setFaultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeGrowthFactor(1.26)
8888
.setFaultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeMin(DataSize.of(4, GIGABYTE))
8989
.setFaultTolerantExecutionArbitraryDistributionWriteTaskTargetSizeMax(DataSize.of(50, GIGABYTE))
9090
.setFaultTolerantExecutionHashDistributionComputeTaskTargetSize(DataSize.of(512, MEGABYTE))

docs/src/main/sphinx/admin/fault-tolerant-execution.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ properties only apply to a ``TASK`` retry policy.
256256
distribution for fault-tolerant execution. Lower bound is 1.0. For every
257257
task size increase, new task target size is old task target size
258258
multiplied by this growth factor.
259-
- ``1.2``
259+
- ``1.26``
260260
* - ``fault-tolerant-execution-arbitrary-distribution-compute-task-target-size-min``
261261
- Initial/minimum target input :ref:`data size <prop-type-data-size>` for
262262
non-writer tasks of arbitrary distribution of fault-tolerant execution.
@@ -274,7 +274,7 @@ properties only apply to a ``TASK`` retry policy.
274274
distribution for fault-tolerant execution. Lower bound is 1.0. For every
275275
task size increase, new task target size is old task target size
276276
multiplied by this growth factor.
277-
- ``1.2``
277+
- ``1.26``
278278
* - ``fault-tolerant-execution-arbitrary-distribution-write-task-target-size-min``
279279
- Initial/minimum target input :ref:`data size <prop-type-data-size>` for
280280
writer tasks of arbitrary distribution of fault-tolerant execution.

0 commit comments

Comments
 (0)