Replace H2 use for testing with PostgreSQL #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jul 9, 2025
|
I ll have to remove that
…On Wed, 9 Jul 2025 at 6:49 AM, Yuya Ebihara ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In webapp/pnpm-lock.yaml
<#719 (comment)>
:
> @@ -1,2936 +0,0 @@
-lockfileVersion: '9.0'
Is this change related to H2 removal?
—
Reply to this email directly, view it on GitHub
<#719 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZQUV6COWOFPLL5UJO33HRUZXAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOJZGQ4DSNRYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
2 times, most recently
from
d8bbdb2 to
c1469cc
Compare
Why do we need to remove |
|
I mean i ll remove that commit
…On Wed, 9 Jul 2025 at 3:24 PM, Yuya Ebihara ***@***.***> wrote:
*ebyhr* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
I ll have to remove that
Why do we need to remove webapp/pnpm-lock.yaml?
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZXSTFAUPT5SWPXZ7RT3HTREZAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJRHE2TANZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
c1469cc to
414ca10
Compare
|
@ebyhr please review |
ebyhr
reviewed
Jul 15, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/persistence/dao/ExactMatchSourceSelectorsDao.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/persistence/dao/ExactMatchSourceSelectorsDao.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/TestingJdbcConnectionManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/TestingJdbcConnectionManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestSpecificDbResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestSpecificDbResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestResourceGroupsManager.java
Outdated
Show resolved
Hide resolved
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
414ca10 to
52aaeaa
Compare
|
@ebyhr have resolved please review. |
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
52aaeaa to
d505b71
Compare
|
|
@mosabua please review. |
https://nexus-iq.visa.com/assets/index.html#/vulnerabilities/CVE-2021-42392
|
|
We cut a new release now .. will hopefully be able to test soon .. can you rebase in the meantime |
|
Sure thing!
…On Fri, 19 Sep 2025 at 1:57 AM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
We cut a new release now .. will hopefully be able to test soon .. can you
rebase in the meantime
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZW2ILDDCWBZ7RQEHGD3TMIR3AVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBZGU4DKMRQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
d505b71 to
11a5dd7
Compare
|
@mosabua please review |
|
With #780 merged now .. can you rebase and adjust and make sure CI passes? |
|
Sure
…On Sun, 12 Oct 2025 at 4:39 AM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
With #780 <#780> merged now
.. can you rebase and adjust and make sure CI passes?
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZSW5GCHXLTFCR5C4ND3XGE2VAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJTG4ZDGNZSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
02e1226 to
48fc01b
Compare
|
please review @mosabua |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:
* Fix some things.