Description
When I checkout a clean version of the main branch, build it and try to run tests there are nine tests which fail, all because of text files that cannot be located. An example of this failure is "TestTimestampConversion", which throws System.IO.FileNotFoundException: trino_test_timestamp_conversion.txt but each test failure is due to a different file.
On closer inspection it looks like these files are present, but are under the scripts folder in the Trino.Client.Test project. Making the following changes to the filenames referred to by trino-csharp/Trino.Client.Test/TrinoClientTests.cs causes the tests to succeed:
- "trino_test_timestamp_conversion.txt" => "scripts/trino_test_timestamp_conversion.txt"
- "zero_rows.txt" => "scripts/zero_rows.txt"
- "trino_cancel.txt" => "scripts/trino_cancel.txt"
- "trino_client_timeout.txt" => "scripts/trino_client_timeout.txt"
- "parameters.txt" => "scripts/parameters.txt"
- "trino_exception_test.txt" => "scripts/trino_exception_test.txt"
- "trino_schema_columns.txt" => "scripts/trino_schema_columns.txt"
- "trino_session_test.txt" => "scripts/trino_session_test.txt"
- "trino_all_types.txt" => "scripts/trino_all_types.txt"
Is it possible I'm just missing a setup step for testing (moving the scripts or executing the tests in a different directory?) or should the changes I described above be applied?
Additionally, when I take a look at the most recent CI run (here) it doesn't look like the tests are run, so if this is a genuine error I think this may be why it wasn't spotted. Should the tests be run on commits to main or was this left out for the time being deliberately?