Use advisory locks to avoid duplicate metrics

trinodb · Sep 21, 2022 · 990dd8e · 990dd8e
1 parent 9a42188
commit 990dd8e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/benchto-service/src/main/java/io/trino/benchto/service/BenchmarkService.java b/benchto-service/src/main/java/io/trino/benchto/service/BenchmarkService.java
@@ -173,6 +173,8 @@ public void finishExecution(String uniqueName, String benchmarkSequenceId, Strin
     private List<Measurement> normalizeMeasurements(List<FlatMeasurement> input)
     {
         // use a lookup map to avoid building a complex SQL query that compares attributes list
+        // acquire a lock to avoid adding multiple metrics with same name and same attributes
+        metricRepo.lock();
         Map<Metric, Metric> metrics = new HashMap<>();
         metricRepo.findAll().forEach(metric -> metrics.put(metric, metric));
         Map<Metric, List<FlatMeasurement>> groups = input.stream()

diff --git a/benchto-service/src/main/java/io/trino/benchto/service/repo/MetricRepo.java b/benchto-service/src/main/java/io/trino/benchto/service/repo/MetricRepo.java
@@ -15,10 +15,13 @@
 
 import io.trino.benchto.service.model.Metric;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
 import org.springframework.stereotype.Repository;
 
 @Repository
 public interface MetricRepo
         extends JpaRepository<Metric, Long>
 {
+    @Query(value = "select pg_advisory_xact_lock(1)", nativeQuery = true)
+    void lock();
 }