This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
feat: Injectable MdcRipple + EventRegistry provider
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove MdcRippleModule, making `MdcRipple` an Injectable class. No longer requiring developers to include MdcRippleModule for each component with a dependency on it. BREAKING CHANGE: `MdcRippleModule` has been removed, please update your code accordingly. Closes #164
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 63.97% 64.22% +0.24%
==========================================
Files 75 75
Lines 3517 3502 -15
Branches 716 712 -4
==========================================
- Hits 2250 2249 -1
+ Misses 1267 1253 -14
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
MdcRippleModuleand refactoredMdcRippleinto an@Injectableclass. Developers no longer need to include a ripple import with each component that required it.BREAKING CHANGE:
MdcRippleModulewas removed, please update your code accordingly.Closes #164