Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

fix(snackbar): Doesn't close while other element is focused #1242

Merged
merged 2 commits into from
Aug 26, 2018

Conversation

trimox
Copy link
Owner

@trimox trimox commented Aug 23, 2018

Snackbar doesn't close when any element on page receives focus event while snackbar is opened and snackbar has empty action text.

reference: material-components/material-components-web#2183

@trimox trimox added the new-mdc-feature Feature incorporated from material-components-web label Aug 23, 2018
@trimox trimox added this to the v0.39.0 milestone Aug 23, 2018
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9fba0ff). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1242   +/-   ##
=========================================
  Coverage          ?   93.25%           
=========================================
  Files             ?      173           
  Lines             ?     6628           
  Branches          ?      970           
=========================================
  Hits              ?     6181           
  Misses            ?      447           
  Partials          ?        0
Impacted Files Coverage Δ
packages/snackbar/snackbar.component.ts 90.17% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fba0ff...89f569f. Read the comment docs.

@trimox trimox merged commit 9f2f912 into master Aug 26, 2018
@trimox trimox deleted the fix/snackbar-focus branch August 26, 2018 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-mdc-feature Feature incorporated from material-components-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant