Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoltan: HSFC curve options #13880

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lkotipal
Copy link
Contributor

@trilinos/Zoltan @egboman

Motivation

Zoltan’s “Octree” Hilbert curve is an implementation of a three-dimensional curve canonized in most implementations. However, it is not unique among space filling curves; Haverkort (2017) describes up to ten million depending on desired properties. Of particular interest to load balancing is Lp-dilation, measuring the maximum Lp-distance between points in space divided by the difference between their Hilbert coordinates. Two particular curves known as the hyperorthogonal curves have optimal locality: Alfa has optimal L∞-dilation, while Beta has optimal L1- and L2-dilation.

This PR implements several curves with the base pattern Ca00 shared with the Octree curve, with state tables calculated adapting the method described by Lawder & King (2001). These include Butz (should effectively be a re-implementation of Octree), Harmonious, Sasburg, Base Camp, and the hyperorthogonal curves. The Z-curve is also implemented in two and three dimensions, mostly as a control. The choice of curve is controlled by the user parameter CURVE, defaulting to the Hilbert curve in two dimensions and the Octree curve in three dimensions, preserving previous behavior. The generation code and state tables (as C arrays) can be found here.

Addresses issue #13879

Testing

Default behaviour (Hilbert curve and Octree partitioning in 2D and 3D respectively) should be exercised by existing tests.

No tests for different curve implementations yet, but functionality and performance have been tested on Vlasiator with promising results; a production scale simulation shows around a 14% improvement on the best curve found (Beta) over the original Octree curve in spatial translation for a 4% improvement in overall simulation time (shown on the two box plots below). We expect these results to be applicable for similar workloads, i.e. Eulerian grids where data needs to be communicated along coordinate axes. In general we expect one of the hyperorthogonal curves to typically be optimal for any workload depending on the communication patterns of the program.

hilberts-Propagate-time
hilberts-Spatial-space-time

Additional Information

Sources cited:

Signed-off-by: Leo Kotipalo <leo.kotipalo@helsinki.fi>
@lkotipal lkotipal requested a review from a team as a code owner March 13, 2025 16:24
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@cgcgcg
Copy link
Contributor

cgcgcg commented Mar 13, 2025

@egboman

@egboman egboman self-assigned this Mar 13, 2025
@egboman
Copy link
Contributor

egboman commented Mar 13, 2025

@lkotipal : Thanks for the PR and the very detailed explanation! There has not been any development in the Zoltan space-filling curves for many years. This looks like a nice addition! I have a couple questions:

  1. Does this PR break backwards compatibility? It looks like the default values of CURVE have been chosen to preserve backwards compatibility, correct?
  2. Does Vlasiator actually use Zoltan with these modifications? Or you developed the space-filling curves in Vlasiator and then decided to contribute to Zoltan?

@lkotipal
Copy link
Contributor Author

@lkotipal : Thanks for the PR and the very detailed explanation! There has not been any development in the Zoltan space-filling curves for many years. This looks like a nice addition! I have a couple questions:

1. Does this PR break backwards compatibility? It looks like the default values of CURVE have been chosen to preserve backwards compatibility, correct?

2. Does Vlasiator actually use Zoltan with these modifications? Or you developed the space-filling curves in Vlasiator and then decided to contribute to Zoltan?
  1. Yep, it defaults to the original state tables when CURVE is not set so behaviour should be unchanged.
  2. We use Zoltan, and the tests were done using the branch on this PR.

Copy link
Contributor

@egboman egboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! The new options will be useful. In particular, the "beta" curve seems to give better results (at least in some cases). We appreciate you contributing this code to Zoltan.

@egboman egboman added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Mar 15, 2025
@egboman
Copy link
Contributor

egboman commented Mar 15, 2025

The failing tests do not seem to be related to this PR. Trying to run them again.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

8 similar comments
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@lkotipal
Copy link
Contributor Author

[2025-03-13T16:25:09Z ERROR verification::job_approver] Initiating User lkotipal is not approved to run jobs on this machine.
[2025-03-13T16:25:09Z INFO verification::job_approver] AT2: Please have someone from Pretest-Inspectors trigger this workflow

Looks like a permissions issue?

@ccober6 ccober6 added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Mar 24, 2025
@trilinos-autotester trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Mar 24, 2025
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1286
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1333
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1332
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1253
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1332
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Using Repos:

Repo: TRILINOS (lkotipal/Trilinos)
  • Branch: more-hilbert-curves
  • SHA: edab773
  • Mode: TEST_REPO

Pull Request Author: lkotipal

@ccober6
Copy link
Contributor

ccober6 commented Mar 24, 2025

FYI, there is a limited list of who can do the Pretest-Inspections. @egboman should be on the list but I went ahead and added the Pretest-Inspection label.

@egboman
Copy link
Contributor

egboman commented Mar 24, 2025

Thanks, @ccober6 . I didn't realize I should do that.

@ccober6
Copy link
Contributor

ccober6 commented Mar 24, 2025

Yeah, there are times when Pretest-Inspected label needs to be added, when the contributor is not on the pretest inspection list.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1286
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1333
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1332
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1253
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1332
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2


CDash Test Results for PR# 13880.


Wiki: How to Reproduce PR Testing Builds and Errors.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Mar 24, 2025
@egboman
Copy link
Contributor

egboman commented Mar 24, 2025

Not sure why some tests failed, looks like they didn't even build correctly?

@ccober6
Copy link
Contributor

ccober6 commented Mar 24, 2025

Maybe DevOps folks can help. @trilinos/framework

@sebrowne
Copy link
Contributor

@ccober6 @egboman the code needs to be "approved" prior to the AT2 system testing changes from outside contributors (via the "review" tab). Then you can go and re-run the GitHub action.

@ccober6 ccober6 self-requested a review March 24, 2025 20:14
Copy link
Contributor

@ccober6 ccober6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ccober6 ccober6 added AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration labels Mar 24, 2025
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1290
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1337
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1336
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1257
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1336
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Using Repos:

Repo: TRILINOS (lkotipal/Trilinos)
  • Branch: more-hilbert-curves
  • SHA: edab773
  • Mode: TEST_REPO

Pull Request Author: lkotipal

@egboman
Copy link
Contributor

egboman commented Mar 24, 2025

Sorry, I don't understand. What kind of approval is needed? There is still a checkmark by my code review, so I believe it is still valid. Same for Curt.

@cgcgcg
Copy link
Contributor

cgcgcg commented Mar 24, 2025

In kicked off all AT2 jobs again. Let's see if that does it.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1290
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1337
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1336
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1257
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1336
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2


CDash Test Results for PR# 13880.


Wiki: How to Reproduce PR Testing Builds and Errors.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Mar 24, 2025
@egboman egboman added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Mar 25, 2025
@egboman
Copy link
Contributor

egboman commented Mar 25, 2025

Failed again... Will keep trying!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1298
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1345
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1344
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1265
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1344
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Using Repos:

Repo: TRILINOS (lkotipal/Trilinos)
  • Branch: more-hilbert-curves
  • SHA: edab773
  • Mode: TEST_REPO

Pull Request Author: lkotipal

@sebrowne
Copy link
Contributor

It appears to be valid build errors in the Intel and Clang configurations. Here's a link to the Intel failures: https://trilinos-cdash.sandia.gov/viewBuildError.php?buildid=2171929

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 1298
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_clang

  • Build Num: 1345
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda

  • Build Num: 1344
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_intel

  • Build Num: 1265
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 1344
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Zoltan;AT: RETEST;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13880
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/lkotipal/Trilinos
TRILINOS_SOURCE_SHA edab773
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1acf4a2


CDash Test Results for PR# 13880.


Wiki: How to Reproduce PR Testing Builds and Errors.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Mar 25, 2025
@cgcgcg cgcgcg added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Mar 25, 2025
@egboman
Copy link
Contributor

egboman commented Mar 26, 2025

After looking at the latest test failures, there are some issues that need to be fixed. Turns out clang and the Intel compilers are more picky than gcc. Unfortunately, the cdash output is internal to Sandia. I will copy-paste some output below. @lkotipal , looks like minor errors so I hope you have a chance to fix this and update the PR. Thanks!

Failing tests (clang):

Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/hsfc/hsfc_hilbert.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/hsfc/hsfc_box_assign.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/hsfc/hsfc.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/hsfc/hsfc_point_assign.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/order/hsfcOrder.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/zz/zz_coord.c.o
Zoltan | Error building packages/zoltan/src/CMakeFiles/zoltan.dir/reftree/reftree_coarse_path.c.o

Source: packages/zoltan/src/hsfc/hsfc_hilbert.c
In file included from ../Trilinos/packages/zoltanhsfc/hsfc_hilbert.c:19:
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:118:51: error: initializer element is not a compile-time constant
static const struct Tables tables2d[N_CURVE2D] = {z2d, hilbert};
^~~
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:1333:51: error: initializer element is not a compile-time constant
static const struct Tables tables3d[N_CURVE3D] = {z3d, octree, butz, alfa, harmonious, sasburg, base_camp, beta};
^~~
2 errors generated.

Source: packages/zoltan/src/hsfc/hsfc_box_assign.c
In file included from ../Trilinos/packages/zoltanhsfc/hsfc_box_assign.c:15:
In file included from ../Trilinos/packages/zoltanhsfc/hsfc.h:24:
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:118:51: error: initializer element is not a compile-time constant
static const struct Tables tables2d[N_CURVE2D] = {z2d, hilbert};
^~~
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:1333:51: error: initializer element is not a compile-time constant
static const struct Tables tables3d[N_CURVE3D] = {z3d, octree, butz, alfa, harmonious, sasburg, base_camp, beta};
^~~
2 errors generated.

Source: packages/zoltan/src/hsfc/hsfc.c
In file included from ../Trilinos/packages/zoltanhsfc/hsfc.c:26:
In file included from ../Trilinos/packages/zoltanhsfc/hsfc.h:24:
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:118:51: error: initializer element is not a compile-time constant
static const struct Tables tables2d[N_CURVE2D] = {z2d, hilbert};
^~~
../Trilinos/packages/zoltanhsfc/hsfc_hilbert_const.h:1333:51: error: initializer element is not a compile-time constant
static const struct Tables tables3d[N_CURVE3D] = {z3d, octree, butz, alfa, harmonious, sasburg, base_camp, beta};
^~~
2 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) pkg: Zoltan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants