Skip to content
This repository was archived by the owner on May 9, 2023. It is now read-only.

Conversation

@tzununbekov
Copy link
Member

@tzununbekov tzununbekov commented Jul 10, 2020

Changes:

  • serverless.yaml manifest supports events schedule:
functions:
  go-lambda:
    source: go-lambda/main.go
    runtime: https://raw.githubusercontent.com/triggermesh/knative-lambda-runtime/master/go-1.x/runtime.yaml
    environment:
      foo: bar
    schedule:
    - cron: "*/5 * * * *"
      jsondata: '{"name":"triggermesh"}'
    - cron: "0 0 * * 6"
      jsondata: '{"weeklyBackup":true}'
      description: "some scheduled action"
  • as a part of required changes knative dependencies were update, eventing legacy client removed ✨
  • integration tests updates

closes #194

@tzununbekov tzununbekov self-assigned this Jul 10, 2020
Comment on lines +31 to +34
knative.dev/eventing v0.15.0
knative.dev/eventing-contrib v0.15.0
knative.dev/pkg v0.0.0-20200708171447-5358179e7499
knative.dev/serving v0.15.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used v0.15.0 knative version since it brought less conflicts to this PR, which scope initially was not about deps update. I'll update dependencies to the latest versions as a part of a separate PR

Copy link

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! A few small comments, mostly about code quality.

Copy link

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@tzununbekov tzununbekov merged commit 2cee6b1 into master Jul 15, 2020
@tzununbekov tzununbekov deleted the service-schedule branch July 19, 2021 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PingSource supported?

4 participants