fix(batch-queue): allow batch queue consumers to run independently from the run engine worker by ericallam · Pull Request #2916 · triggerdotdev/trigger.dev

ericallam · 2026-01-20T15:08:33Z

new environment variable BATCH_QUEUE_WORKER_ENABLED now can be used
independently from RUN_ENGINE_WORKER_ENABLED

…om the run engine worker new environment variable `BATCH_QUEUE_WORKER_ENABLED` now can be used independently from `RUN_ENGINE_WORKER_ENABLED`

changeset-bot · 2026-01-20T15:08:38Z

⚠️ No Changeset found

Latest commit: b4b4c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-20T15:08:58Z

Walkthrough

This pull request adds a new BATCH_QUEUE_WORKER_ENABLED environment variable to control batch queue consumer activation. The variable is added to the environment schema with a default value of true, then passed to RunEngine through a new consumerEnabled property in the batchQueue configuration object. The RunEngine initialization logic is updated to use this flag instead of the previous worker.disabled condition to determine whether consumers should start. A corresponding type definition is added to RunEngineOptions.batchQueue. Minor formatting and structural adjustments are made throughout the engine initialization code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is minimal and does not follow the provided template structure, missing required sections like Testing, Changelog, and the checklist.	Add the template sections including Testing steps, a detailed Changelog entry, and complete the contribution checklist to provide complete context for reviewers.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main change: introducing independent control for batch queue consumers via a new environment variable, decoupling them from the run engine worker.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧹 Recent nitpick comments

internal-packages/run-engine/src/engine/index.ts (1)
331-361: Fix misleading comment about consumer enablement.

The logic is correct, but the comment references consumerDisabled and reads inverted relative to consumerEnabled.
Proposed fix
-    // Only start consumers if consumerDisabled is not set or is false
+    // Start consumers unless consumerEnabled is explicitly false
     const startBatchQueueConsumers = options.batchQueue?.consumerEnabled ?? true;
apps/webapp/app/v3/runEngine.server.ts (1)
159-182: Update the batch consumer comment to reflect the new flag.

The wiring is correct, but the comment still refers to options.worker.disabled.
Proposed fix
-    // Consumers are controlled by options.worker.disabled (same as main worker)
+    // Consumers are controlled by batchQueue.consumerEnabled (BATCH_QUEUE_WORKER_ENABLED)

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8716752 and b4b4c0f.

📒 Files selected for processing (4)

apps/webapp/app/env.server.ts
apps/webapp/app/v3/runEngine.server.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Always import tasks from @trigger.dev/sdk, never use @trigger.dev/sdk/v3 or deprecated client.defineJob pattern
Every Trigger.dev task must be exported and have a unique id property with no timeouts in the run function

Files:

apps/webapp/app/env.server.ts
internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

apps/webapp/app/env.server.ts
apps/webapp/app/v3/runEngine.server.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Import from @trigger.dev/core using subpaths only, never import from root

Files:

apps/webapp/app/env.server.ts
internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Access all environment variables through the env export of env.server.ts instead of directly accessing process.env in the Trigger.dev webapp

Files:

apps/webapp/app/env.server.ts
apps/webapp/app/v3/runEngine.server.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: When importing from @trigger.dev/core in the webapp, use subpath exports from the package.json instead of importing from the root path
Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Access environment variables via env export from apps/webapp/app/env.server.ts, never use process.env directly

Files:

apps/webapp/app/env.server.ts
apps/webapp/app/v3/runEngine.server.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

apps/webapp/app/env.server.ts
internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

apps/webapp/app/env.server.ts
internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

🧠 Learnings (11)

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/app/**/*.{ts,tsx} : Access all environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env` in the Trigger.dev webapp

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2026-01-15T11:50:06.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.044Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : Access environment variables via `env` export from `apps/webapp/app/env.server.ts`, never use `process.env` directly

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2025-08-14T18:35:44.370Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2390
File: apps/webapp/app/env.server.ts:764-765
Timestamp: 2025-08-14T18:35:44.370Z
Learning: The BoolEnv helper in apps/webapp/app/utils/boolEnv.ts uses z.preprocess with inconsistent default value types across the codebase - some usages pass boolean defaults (correct) while others pass string defaults (incorrect), leading to type confusion. The helper should enforce boolean-only defaults or have clearer documentation.

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `runs.subscribeToBatch()` to subscribe to changes for all runs in a batch

Applied to files:

internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Control concurrency using the `queue` property with `concurrencyLimit` option

Applied to files:

internal-packages/run-engine/src/engine/types.ts

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Use the Run Engine 2.0 from `internal/run-engine` for new run lifecycle code in the webapp instead of the legacy run engine

Applied to files:

internal-packages/run-engine/src/engine/index.ts
apps/webapp/app/v3/runEngine.server.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Subscribe to run updates using `runs.subscribeToRun()` for realtime monitoring of task execution

Applied to files:

internal-packages/run-engine/src/engine/index.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `runs.subscribeToRunsWithTag()` to subscribe to all runs with a specific tag

Applied to files:

internal-packages/run-engine/src/engine/index.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Attach metadata to task runs using the metadata option when triggering, and access/update it inside runs using metadata functions

Applied to files:

internal-packages/run-engine/src/engine/index.ts

📚 Learning: 2024-10-18T15:41:52.352Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 1418
File: packages/core/src/v3/errors.ts:364-371
Timestamp: 2024-10-18T15:41:52.352Z
Learning: In `packages/core/src/v3/errors.ts`, within the `taskRunErrorEnhancer` function, `error.message` is always defined, so it's safe to directly call `error.message.includes("SIGTERM")` without additional checks.

Applied to files:

internal-packages/run-engine/src/engine/index.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Configure task retry behavior using the `retry` property with options like maxAttempts, factor, and timeout values

Applied to files:

internal-packages/run-engine/src/engine/index.ts

🧬 Code graph analysis (1)

apps/webapp/app/v3/runEngine.server.ts (3)

apps/webapp/app/env.server.ts (1)

env (1321-1321)

apps/supervisor/src/env.ts (1)

env (139-139)

internal-packages/run-engine/src/run-queue/fairQueueSelectionStrategy.ts (4)

env (502-522)

env (561-579)

env (581-595)

env (597-617)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)

GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: typecheck / typecheck
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (6)

apps/webapp/app/env.server.ts (1)

955-955: LGTM: batch queue worker flag defaults to enabled.

The BoolEnv default aligns with the new consumer-enabled wiring.

internal-packages/run-engine/src/engine/types.ts (1)

83-83: LGTM: batchQueue consumer toggle surfaced in options.

internal-packages/run-engine/src/engine/index.ts (4)

200-209: No review note.

460-479: LGTM: trailing debounce now updates payload/metadata.

573-605: No review note.

1750-1782: No review note.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2026-01-20T15:11:11Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

fix(batch-queue): allow batch queue consumers to run independently fr…

b4b4c0f

…om the run engine worker new environment variable `BATCH_QUEUE_WORKER_ENABLED` now can be used independently from `RUN_ENGINE_WORKER_ENABLED`

ericallam marked this pull request as ready for review January 20, 2026 15:21

mpcgrid approved these changes Jan 20, 2026

View reviewed changes

ericallam merged commit 8bc6b99 into main Jan 20, 2026
32 checks passed

ericallam deleted the ea-branch-114 branch January 20, 2026 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(batch-queue): allow batch queue consumers to run independently from the run engine worker#2916

fix(batch-queue): allow batch queue consumers to run independently from the run engine worker#2916
ericallam merged 1 commit intomainfrom
ea-branch-114

ericallam commented Jan 20, 2026

Uh oh!

changeset-bot bot commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

vibe-kanban-cloud bot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ericallam commented Jan 20, 2026

Uh oh!

changeset-bot bot commented Jan 20, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

vibe-kanban-cloud bot commented Jan 20, 2026

Review Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 20, 2026 •

edited

Loading