Skip to content

Feat: supervisor ARM builds #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2025
Merged

Feat: supervisor ARM builds #2046

merged 11 commits into from
May 14, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented May 14, 2025

Also, semver tags will now push to v4-beta as well.

Summary by CodeRabbit

  • Chores
    • Updated Docker image tagging logic in deployment workflows to use a new beta tag for semantic version releases.
    • Streamlined build and push process in deployment workflows by integrating Depot CLI and simplifying steps.
    • Enhanced Dockerfile for the supervisor app by installing additional system packages required for building dependencies.

Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 0691f98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 14, 2025

Walkthrough

The changes update Docker image tagging logic in GitHub Actions workflows to use a v4-beta tag for semantic version tags instead of v3, with a placeholder for future v4 GA. The build and push process for worker images is streamlined using the Depot CLI. Additional build dependencies are installed in the supervisor app's Dockerfile.

Changes

File(s) Change Summary
.github/workflows/publish-webapp.yml Changed Docker image tagging: semver tags now also receive v4-beta (was v3); updated related comments.
.github/workflows/publish-worker-v4.yml Added Depot CLI setup, streamlined build/push with depot/build-push-action, changed semver tag to v4-beta.
apps/supervisor/Containerfile Added installation of extra Alpine packages (python3-dev, py3-setuptools, make, g++, gcc, linux-headers) in the deps-fetcher stage.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Depot CLI
    participant GitHub Container Registry

    GitHub Actions->>Depot CLI: Setup Depot CLI
    GitHub Actions->>Depot CLI: Build and push Docker image (with computed tags)
    Depot CLI->>GitHub Container Registry: Push image (tags include v4-beta if semver)
Loading

Possibly related PRs

  • #1790: Also modifies the supervisor Containerfile to restructure dependency stages and fix build issues.
  • #2018: Comments out the step pushing the v3 tag in a related workflow, showing overlap in image tagging logic.
  • #1306: Introduces a custom GitHub Action for determining image tags and semver status, directly related to tag handling.

Suggested reviewers

  • matt-aitken

Poem

In the warren where containers hop,
New tags now bloom atop the crop—
v4-beta leaps where v3 once lay,
With Depot’s paws, builds speed away.
Supervisor munches dependencies anew,
Hopping forward, as all good bunnies do! 🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ace1c3 and 0691f98.

📒 Files selected for processing (3)
  • .github/workflows/publish-webapp.yml (1 hunks)
  • .github/workflows/publish-worker-v4.yml (3 hunks)
  • apps/supervisor/Containerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: units / 🧪 Unit Tests
🔇 Additional comments (7)
apps/supervisor/Containerfile (1)

22-22: Adding necessary build dependencies for ARM support

These Alpine packages provide the essential build tools and headers required for compiling native dependencies across multiple architectures, particularly ARM. This addition supports the PR's objective of enabling ARM builds for the supervisor component.

.github/workflows/publish-webapp.yml (1)

46-50: Version tagging updated to v4-beta

The tagging strategy has been appropriately updated to use v4-beta for semantic version tags, with a clear TODO note for the future GA transition to v4. This change aligns with the PR objective to update the semver tagging process.

.github/workflows/publish-worker-v4.yml (5)

17-17: Added required id-token write permission for Depot

This permission is necessary for the Depot CLI authentication process.


39-41: Added Depot CLI setup

The Depot CLI setup is correctly implemented to enable faster multi-platform Docker builds.


56-57: Improved step naming for clarity

The step name now uses an emoji prefix for better visual scanning of the workflow logs.


62-74: Standardized tag construction logic

This implementation correctly builds the image tags string, adding the v4-beta tag for semantic versions. The approach is consistent with the webapp workflow and supports the PR's objective to update the semver tagging process.


83-89: Streamlined build process with multi-architecture support

This change effectively:

  1. Replaces manual Docker commands with the simplified Depot action
  2. Adds ARM64 platform support (alongside AMD64)
  3. Uses the same image tag construction as previously defined

This implementation directly addresses the PR's primary objective of adding ARM builds for the supervisor component.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nicktrn nicktrn merged commit fa5360a into main May 14, 2025
12 of 13 checks passed
@nicktrn nicktrn deleted the feat/arm-workers branch May 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants