Skip to content

RunTimeline: Fix for long file names wrapping instead of truncating #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Apr 7, 2025

Long file names now truncate instead of wrap

CleanShot 2025-04-07 at 15 59 13

Summary by CodeRabbit

  • Style
    • Enhanced the visual presentation of timeline events for a more polished user experience.
    • Refined tooltip displays to handle text overflow gracefully, ensuring clear, concise information.
    • Updated subtitle formatting to maintain a consistent single-line presentation.

Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: bcf4e50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

Walkthrough

The changes update the styling and layout of the RunTimelineEvent component in the web application. Modifications include updating the tooltip trigger container with min-w-0 and max-w-full classes to improve overflow handling, changing the title element from a span to a div with the truncate class for text overflow, and applying the whitespace-nowrap class to the subtitle element to keep it on a single line. No changes were made to the exported or public declarations.

Changes

File(s) Change Summary
apps/.../RunTimeline.tsx Updated tooltip trigger container by adding min-w-0 and max-w-full classes; changed title element from span to div with the truncate class; applied whitespace-nowrap to subtitle.

Suggested reviewers

  • matt-aitken

Poem

I'm a bunny with a coding beat,
Hop through code with nimble feet.
I saw some classes get a hop,
Overflow handled—no need to stop.
Celebrating changes, oh so neat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc0a331 and bcf4e50.

📒 Files selected for processing (1)
  • apps/webapp/app/components/run/RunTimeline.tsx (2 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
apps/webapp/app/components/run/RunTimeline.tsx (1)
apps/webapp/app/components/primitives/Tooltip.tsx (3)
  • TooltipProvider (118-118)
  • Tooltip (118-118)
  • TooltipTrigger (118-118)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
apps/webapp/app/components/run/RunTimeline.tsx (4)

348-348: Good addition of min-w-0 to the container.

Adding min-w-0 to the flex container allows its children to shrink below their minimum content width, which is essential for text truncation to work properly in flex layouts.


351-351: Improved tooltip container for better overflow handling.

The addition of min-w-0 max-w-full to the tooltip trigger allows it to both shrink when needed and respect container boundaries, which enables proper text truncation.


352-352: Good implementation of text truncation.

Changing from a span to a div and adding the truncate class provides the necessary CSS properties (overflow: hidden, text-overflow: ellipsis, and white-space: nowrap) to properly truncate long filenames with an ellipsis.


362-364: Prevents subtitle wrapping.

Adding whitespace-nowrap ensures the timestamp/subtitle stays on a single line, maintaining consistent vertical alignment with the truncated title.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit b322cf1 into main Apr 7, 2025
13 checks passed
@matt-aitken matt-aitken deleted the fix-for-long-imported-names branch April 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants