Enhance RunTag parsing with robust key-value tag splitting #1782
Conversation
|
WalkthroughThis pull request refactors the Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/webapp/app/components/runs/v3/RunTag.tsx (2)
37-38: Consider elaborating on the fallback logic in the doc comment.
The doc mentions "special handling for common ID formats," but you might want to clarify how multiple separators (colons/underscores) lead to either a split or falling back to the entire string. That extra detail would help maintainers quickly grasp the intention behind the conditions.
40-63: Consider extracting the ID detection into a dedicated helper function.
Overall, the splitting logic is concise and thoroughly tested. Still, the code checks multiple conditions for “likely IDs,” which can be slightly complex to parse at first glance. Extracting that part into a small helper (e.g.,function isLikelyIDFormat(tag, key, value)) could improve readability and maintainability without changing functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/webapp/app/components/runs/v3/RunTag.tsx(1 hunks)apps/webapp/test/components/runs/v3/RunTag.test.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
🔇 Additional comments (3)
apps/webapp/test/components/runs/v3/RunTag.test.ts (3)
4-41: Add test coverage for empty key scenarios.
These tests for returning the original string or creating key-value pairs cover many separators. However, consider adding a test for an empty key, e.g.":someValue"or"_someValue", to confirm the function correctly returns the entire tag. This ensures that every corner case is handled.
43-66: Thorough coverage of 12-character keys, empty values, and special characters.
All scenarios appear consistent with the intended parsing behavior. No concerns here.
68-77: Good coverage of numeric keys and complex mixed delimiters.
This suite of tests validates that numeric characters in the key and multi-delimiter scenarios behave properly. Looks good.
Hi, there was no issue linked to it so that's why it was left blank. I'll update it :) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (14)
docs/guides/examples/puppeteer.mdx (1)
208-208: Improvement Suggestion: Refine Warning Message GrammarThe updated warning clearly emphasizes the need to proxy requests and obtain permission from the website owner. However, the sentence "If you don't you'll risk getting our IP address blocked and we will ban you from our service." could be improved for clarity. Consider adding a comma before "and" (i.e. "you'll risk getting our IP address blocked, and we will ban you…") to better separate the two independent clauses.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~208-~208: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...u'll risk getting our IP address blocked and we will ban you from our service. You m...(COMMA_COMPOUND_SENTENCE)
ai/references/repo.md (2)
18-27: Internal Packages Section: Minor Typographical Improvements
- Line 20: Consider adding a comma after “usually” to improve readability. For example:
"...not published, and usually, they have a tsc build step and are used in the webapp"- Line 22: Replace “it's lifecycle” with “its lifecycle” to correctly use the possessive form.
🧰 Tools
🪛 LanguageTool
[typographical] ~20-~20: Consider adding a comma after ‘usually’ for more clarity.
Context: ...sed internally only, not published, and usually they have a tsc build step and are used...(RB_LY_COMMA)
[uncategorized] ~22-~22: Did you mean “its” (the possessive pronoun)?
Context: ...andles moving a run all the way through it's lifecycle - /internal-packages/re...(ITS_PREMIUM)
23-23: Typo Correction in Internal PackagesThere is a minor typographical error on this line: "sytem" should be corrected to "system".
ai/references/tests.md (3)
24-26: Rephrase 'almost NEVER' for Improved ClarityThe sentence in line 26 uses the phrase "almost NEVER," which can be simplified to enhance readability and professionalism.
-We use vitest for testing. We almost NEVER mock anything. Start with a top-level "describe", and have multiple "it" statements inside of it. +We use Vitest for testing and rarely use mocks. Begin with a top-level "describe" block and include multiple "it" statements.🧰 Tools
🪛 LanguageTool
[style] ~26-~26: ‘almost NEVER’ might be wordy. Consider a shorter alternative.
Context: ...ng Tests We use vitest for testing. We almost NEVER mock anything. Start with a top-level "...(EN_WORDINESS_PREMIUM_ALMOST_NEVER)
28-29: Clarify Testcontainers Usage for Database-dependent TestsThe current wording could be made clearer. Consider rephrasing the sentence to better communicate that internal testcontainers automatically spin up local instances for Redis or PostgreSQL when needed.
-When writing anything that needs redis or postgresql, we have some internal "testcontainers" that are used to spin up a local instance, redis, or both. +For tests requiring Redis or PostgreSQL, use our internal "testcontainers" to automatically provision local instances.
71-82: Enhance Diction in the Dos and Don'ts SectionThe "Dos and Don'ts" guidelines provide comprehensive best practices; however, several bullet points start with the same phrasing, which could be varied for improved readability. Consider rewording to avoid repetitive language. For example:
- - Do not mock anything. - - Do not use mocks in tests. - - Do not use spies in tests. - - Do not use stubs in tests. - - Do not use fakes in tests. - - Do not use sinon in tests. - - Structure each test with a setup, action, and assertion style. - - Feel free to write long test names. - - If there is any randomness in the code under test, use `seedrandom` to make it deterministic by allowing the caller to provide a seed. + - Avoid mocking in tests. + - Refrain from using additional mocks. + - Avoid using spies. + - Avoid relying on stubs. + - Steer clear of fakes. + - Refrain from using sinon. + - Structure tests with clear setup, action, and assertion phases. + - Use descriptive test names. + - If randomness exists in the code under test, employ `seedrandom` to ensure deterministic behavior by allowing a seed to be provided.🧰 Tools
🪛 LanguageTool
[style] ~75-~75: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nything. - Do not use mocks in tests. - Do not use spies in tests. - Do not use st...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~76-~76: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use spies in tests. - Do not use stubs in tests. - Do not use fa...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~77-~77: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use stubs in tests. - Do not use fakes in tests. - Do not use si...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~78-~78: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use fakes in tests. - Do not use sinon in tests. - Structure eac...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~80-~80: The phrase ‘feel free to’ is used quite frequently. Consider using a less frequent alternative to set your writing apart from others and make it sound more professional.
Context: ...a setup, action, and assertion style. - Feel free to write long test names. - If there is an...(FEEL_FREE_TO_STYLE_ME)
CONTRIBUTING.md (3)
167-167: Minor phrasing improvement opportunityThe phrase "inside of" is redundant - consider simplifying to just "inside".
-6. If you make any changes in the CLI/Core/SDK, you'll need to `CTRL+C` to exit the `dev` command and restart it to pickup changes. Any changes to the files inside of the `v3-catalog/src/trigger` dir will automatically be rebuilt by the `dev` command. +6. If you make any changes in the CLI/Core/SDK, you'll need to `CTRL+C` to exit the `dev` command and restart it to pickup changes. Any changes to the files inside the `v3-catalog/src/trigger` dir will automatically be rebuilt by the `dev` command.🧰 Tools
🪛 LanguageTool
[style] ~167-~167: This phrase is redundant. Consider using “inside”.
Context: ...ickup changes. Any changes to the files inside of thev3-catalog/src/triggerdir will a...(OUTSIDE_OF)
169-169: Missing comma in compound sentenceConsider adding a comma before "and" to improve readability in this compound sentence.
-7. Navigate to the `v3-catalog` project in your local dashboard at localhost:3030 and you should see the list of tasks. +7. Navigate to the `v3-catalog` project in your local dashboard at localhost:3030, and you should see the list of tasks.🧰 Tools
🪛 LanguageTool
[uncategorized] ~169-~169: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...n your local dashboard at localhost:3030 and you should see the list of tasks. 8. G...(COMMA_COMPOUND_SENTENCE)
242-245: Missing language specification in code blockThe fenced code block is missing a language specifier, which would improve syntax highlighting. Also consider consolidating with the previous paragraph for better flow.
-4. Run the migration. - -``` -pnpm run db:migrate:deploy -pnpm run generate -``` - -This executes the migrations against your database and applies changes to the database schema(s), and then regenerates the Prisma client. +4. Run the migration. + +```sh +pnpm run db:migrate:deploy +pnpm run generate +``` + +This executes the migrations against your database and applies changes to the database schema(s), and then regenerates the Prisma client.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
242-242: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
docs/guides/python/python-crawl4ai.mdx (5)
10-14: Prerequisites Section – Consider Punctuation ConsistencyThe list items under prerequisites are clear. For enhanced consistency in documentation style, consider ending list items with consistent punctuation (e.g., a period).
🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: A punctuation mark might be missing here.
Context: ... A project with Trigger.dev initialized - Python install...(AI_EN_LECTOR_MISSING_PUNCTUATION)
19-24: Features List Enhancements
- For the "Crawl4AI" item (line 23), consider hyphenating the compound modifier to “LLM‐friendly” for clarity.
- In line 24, the phrase “headless chromium browser” should use a capital “C” for “Chromium” to reflect the proper noun.
A possible diff for line 24:
- - A custom [Playwright extension](https://playwright.dev/) to create a headless chromium browser + - A custom [Playwright extension](https://playwright.dev/) to create a headless Chromium browser🧰 Tools
🪛 LanguageTool
[uncategorized] ~23-~23: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...ps://github.com/unclecode/crawl4ai), an open source LLM friendly web crawler - A custom [Pl...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~24-~24: The proper noun “Chromium” (= software from Google) needs to be capitalized.
Context: ...//playwright.dev/) to create a headless chromium browser ## GitHub...(GOOGLE_PRODUCTS)
45-97: Build Configuration Code Snippet ReviewThe code snippet for the build configuration is clear and well-commented. A small nitpick: in the command on line 79, consider capitalizing “chromium” to “Chromium” for proper naming consistency. For example:
- `RUN PLAYWRIGHT_BROWSERS_PATH=/ms-playwright python -m playwright install --with-deps chromium`, + `RUN PLAYWRIGHT_BROWSERS_PATH=/ms-playwright python -m playwright install --with-deps Chromium`,Review the official documentation to ensure that the change does not affect the command’s functionality.
136-157: Python Script Example – Import Style ConsiderationThe Python script demonstrates a clear asynchronous web crawl operation using Crawl4AI. A minor suggestion: avoid using wildcard imports (e.g.,
from crawl4ai import *) to prevent namespace pollution and enhance code clarity. For example, if onlyAsyncWebCrawleris required, consider:- from crawl4ai import * + from crawl4ai import AsyncWebCrawler
159-166: Testing Instructions – Correcting Duplicate WordingThere are a couple of duplications in the testing instruction text:
- In the step about copying the project ref, “and and” appears.
- In the step regarding running the CLI command, “with with” is duplicated.
Proposed diffs:
- 4. If you haven't already, copy your project ref from your [Trigger.dev dashboard](https://cloud.trigger.dev) and and add it to the `trigger.config.ts` file. + 4. If you haven't already, copy your project ref from your [Trigger.dev dashboard](https://cloud.trigger.dev) and add it to the `trigger.config.ts` file.- 5. Run the Trigger.dev dev CLI command with with `npx trigger dev@latest dev` (it may ask you to authorize the CLI if you haven't already). + 5. Run the Trigger.dev dev CLI command with `npx trigger dev@latest dev` (it may ask you to authorize the CLI if you haven't already).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
.cursor/rules/executing-commands.mdc(1 hunks).cursor/rules/repo.mdc(1 hunks).cursor/rules/webapp.mdc(1 hunks).cursor/rules/writing-tests.mdc(1 hunks).cursorignore(1 hunks)CONTRIBUTING.md(3 hunks)ai/references/repo.md(1 hunks)ai/references/tests.md(1 hunks)docs/docs.json(11 hunks)docs/guides/examples/puppeteer.mdx(1 hunks)docs/guides/introduction.mdx(1 hunks)docs/guides/python/python-crawl4ai.mdx(1 hunks)docs/snippets/python-learn-more.mdx(1 hunks)references/v3-catalog/.env.example(1 hunks)
✅ Files skipped from review due to trivial changes (6)
- .cursorignore
- .cursor/rules/writing-tests.mdc
- .cursor/rules/executing-commands.mdc
- docs/snippets/python-learn-more.mdx
- docs/docs.json
- .cursor/rules/repo.mdc
🧰 Additional context used
🪛 LanguageTool
docs/guides/examples/puppeteer.mdx
[uncategorized] ~208-~208: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...u'll risk getting our IP address blocked and we will ban you from our service. You m...
(COMMA_COMPOUND_SENTENCE)
CONTRIBUTING.md
[style] ~167-~167: This phrase is redundant. Consider using “inside”.
Context: ...ickup changes. Any changes to the files inside of the v3-catalog/src/trigger dir will a...
(OUTSIDE_OF)
[uncategorized] ~169-~169: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...n your local dashboard at localhost:3030 and you should see the list of tasks. 8. G...
(COMMA_COMPOUND_SENTENCE)
[style] ~173-~173: The phrase ‘feel free to’ is used quite frequently. Consider using a less frequent alternative to set your writing apart from others and make it sound more professional.
Context: ...ny of them accept an empty payload. 9. Feel free to add additional files in `v3-catalog/src...
(FEEL_FREE_TO_STYLE_ME)
docs/guides/python/python-crawl4ai.mdx
[uncategorized] ~12-~12: A punctuation mark might be missing here.
Context: ... A project with Trigger.dev initialized - Python install...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~23-~23: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...ps://github.com/unclecode/crawl4ai), an open source LLM friendly web crawler - A custom [Pl...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~24-~24: The proper noun “Chromium” (= software from Google) needs to be capitalized.
Context: ...//playwright.dev/) to create a headless chromium browser ## GitHub...
(GOOGLE_PRODUCTS)
[duplication] ~167-~167: Possible typo: you repeated a word.
Context: ...v dashboard](https://cloud.trigger.dev) and and add it to the trigger.config.ts file....
(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~168-~168: Possible typo: you repeated a word.
Context: ...ger.config.tsfile. 5. Run the Trigger.dev dev CLI command with withnpx trigger dev@...
(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~168-~168: Possible typo: you repeated a word.
Context: ... 5. Run the Trigger.dev dev CLI command with with npx trigger dev@latest dev (it may as...
(ENGLISH_WORD_REPEAT_RULE)
ai/references/repo.md
[typographical] ~20-~20: Consider adding a comma after ‘usually’ for more clarity.
Context: ...sed internally only, not published, and usually they have a tsc build step and are used...
(RB_LY_COMMA)
[uncategorized] ~22-~22: Did you mean “its” (the possessive pronoun)?
Context: ...andles moving a run all the way through it's lifecycle - /internal-packages/re...
(ITS_PREMIUM)
ai/references/tests.md
[style] ~26-~26: ‘almost NEVER’ might be wordy. Consider a shorter alternative.
Context: ...ng Tests We use vitest for testing. We almost NEVER mock anything. Start with a top-level "...
(EN_WORDINESS_PREMIUM_ALMOST_NEVER)
[style] ~75-~75: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nything. - Do not use mocks in tests. - Do not use spies in tests. - Do not use st...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~76-~76: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use spies in tests. - Do not use stubs in tests. - Do not use fa...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~77-~77: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use stubs in tests. - Do not use fakes in tests. - Do not use si...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~78-~78: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n tests. - Do not use fakes in tests. - Do not use sinon in tests. - Structure eac...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~80-~80: The phrase ‘feel free to’ is used quite frequently. Consider using a less frequent alternative to set your writing apart from others and make it sound more professional.
Context: ...a setup, action, and assertion style. - Feel free to write long test names. - If there is an...
(FEEL_FREE_TO_STYLE_ME)
🪛 markdownlint-cli2 (0.17.2)
CONTRIBUTING.md
242-242: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: typecheck / typecheck
🔇 Additional comments (24)
ai/references/repo.md (5)
1-3: Overall Repo Overview Section is ClearThe introduction and overview provide a concise summary of the monorepo’s structure and tooling. It clearly informs readers about the package management and build system (pnpm and turborepo).
5-9: Apps Section Documentation ReviewThe "Apps" section effectively describes the two primary applications, including their purposes. The details help new contributors understand the role of each app within the repository.
10-17: Public Packages Section Provides Useful ReferencesThe documentation for public packages is well-organized and links to relevant external documentation. This provides a good guide for users exploring the SDK and CLI packages.
28-31: References Section is Well-DocumentedThis section clearly outlines the purpose of the test workspaces. The explanation is concise and beneficial for developers looking to understand testing setups within the repository.
32-38: Other Resources Section is InformativeThe "Other" section provides valuable information about additional resources such as documentation sites, Docker configurations, and contribution guidelines. The reference to the local development command (
pnpm run docker) is especially helpful.ai/references/tests.md (7)
1-3: Clear Documentation for Running TestsThe introduction clearly explains that Vitest is exclusively used for testing. The formatting and hierarchy are appropriately used and help guide the reader.
5-7: Command Example for Executing Workspace TestsThe code snippet demonstrating how to run tests for a specific workspace is clear and correctly formatted.
9-14: Example for Running Tests on a Single FileThe instructions for executing tests on a single file by changing directories and running a command are concise and easy to follow.
16-22: Building Dependencies Before Running TestsThis section effectively explains that building dependencies may be required before running tests, and the provided code block clearly illustrates the process.
30-45: Redis Test Example is Well-StructuredThe Redis test example, including the import statements and test structure, is concise and follows best practices. This example effectively illustrates how to use the internal Redis test setup.
47-57: Postgres Test Example is Clear and InformativeThe PostgreSQL test example is straightforward. The comment clarifying that
prismais an instance of PrismaClient adds necessary context for readers.
59-69: Container Test Example Demonstrates Combined Service TestingThe container test example clearly shows how to test scenarios that require both Prisma and Redis. This example is easy to understand and well-documented.
references/v3-catalog/.env.example (1)
6-7: Database configuration strings added appropriatelyThe addition of
DATABASE_URLandDATABASE_URL_UNPOOLEDenvironment variables provides necessary database connectivity configuration for the v3-catalog application, which aligns with the Prisma setup mentioned in the CONTRIBUTING.md changes.CONTRIBUTING.md (2)
138-139: Improved build command to include packagesThe build command now correctly includes both the CLI and all Trigger.dev packages using the filter pattern. This ensures that all necessary dependencies are built properly for the v3-catalog testing environment.
146-151: Added Prisma setup instructionsThese new steps for Prisma setup and database migration are essential for developers to properly configure the database backend. The commands are clear and provide the necessary steps to deploy migrations and generate Prisma client files.
.cursor/rules/webapp.mdc (1)
1-37: Well-structured documentation for the webapp architectureThis new file provides excellent documentation about the webapp structure, subsystems, and development practices. It covers key aspects including:
- The tech stack (Remix 2.1.0, Express, TypeScript)
- Subsystems and dependencies
- Environment variable handling
- Testing practices
- Legacy vs. new Run Engine 2.0
- Code location references
This documentation will be valuable for onboarding new developers and understanding the codebase organization.
docs/guides/introduction.mdx (1)
48-48: New Python example project added appropriatelyThe addition of the Python web crawler example project is well-formatted and consistent with the existing table structure. It provides a valuable new example using Python, Crawl4AI, and Playwright, expanding the range of examples available to users.
docs/guides/python/python-crawl4ai.mdx (7)
1-5: Front Matter and Header DefinitionThe YAML header is clear and well-structured, providing a concise title, sidebar title, and description for the document.
7-8: Import Statements for MDX ComponentsThe imports for
ScrapingWarningandPythonLearnMoreare correctly set up to include external MDX snippets.
15-18: Overview Section ClarityThe overview is concise and explains the demo’s purpose effectively. No changes are needed.
28-37: GitHub Repository Card ComponentThe GitHub repo section is implemented with a Card component that clearly links to the examples repository. The content is informative and encourages reuse.
101-125: Task Code Snippet EvaluationThe task code snippet using
python.runScriptis well-structured and demonstrates proper usage of the Trigger.dev SDK along with logging.
127-134: Requirements.txt File ContentThe
requirements.txtsnippet correctly lists the necessary dependencies. This is clear and concise.
167-171: Deployment InstructionsThe deployment instructions are straightforward, clearly detailing the CLI command for production deployment and referencing additional learning resources via
<PythonLearnMore />.🧰 Tools
🪛 LanguageTool
[duplication] ~167-~167: Possible typo: you repeated a word.
Context: ...v dashboard](https://cloud.trigger.dev) and and add it to thetrigger.config.tsfile....(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~168-~168: Possible typo: you repeated a word.
Context: ...ger.config.tsfile. 5. Run the Trigger.dev dev CLI command with withnpx trigger dev@...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~168-~168: Possible typo: you repeated a word.
Context: ... 5. Run the Trigger.dev dev CLI command with withnpx trigger dev@latest dev(it may as...(ENGLISH_WORD_REPEAT_RULE)
There was a problem hiding this comment.
@iFlyinq
If the PR is not related to an issue then create an issue then attach the issue into the PR, ask the maintainers about the issue
and secondly the ci checks are failing kindly resolve them
There was a problem hiding this comment.
@iFlyinq brilliant!
It will be a couple of weeks before this gets deployed to cloud because we're in a final push for v4 so there's a freeze for anything that isn't a critical hotfix.
Here's a filled-out PR description based on the changes:
✅ Checklist
Testing
This PR includes unit tests for
splitTagto ensure robust parsing of key-value tags. The tests verify:_and:as delimiters.Changelog
Enhancements
splitTagfunction for more robust key-value splitting.Tests
splitTaginRunTag.test.ts.💯
Summary by CodeRabbit
.cursorignorefile to specify paths to be excluded from tracking.