Skip to content

missing construction option in AudioWaveformExtension #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

zvictor
Copy link
Contributor

@zvictor zvictor commented Feb 9, 2025

Small fix for a missing argument.

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

It's a tiny change. I admit I have not bothered testing it.

The PR title follows the convention.

What convention? Where is it? Couldn't find in the CONTRIBUTING.md

Summary by CodeRabbit

  • New Features
    • The audio waveform functionality now accepts custom configuration options, allowing users to specify values such as version and checksum for a more tailored audio experience.
  • Bug Fixes
    • A patch has been introduced for the @trigger.dev/build package to address a missing construction option in the AudioWaveformExtension.

Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: 55afe3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/core Patch
@trigger.dev/react-hooks Patch
@trigger.dev/rsc Patch
@trigger.dev/sdk Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
@internal/redis-worker Patch
@internal/zod-worker Patch
references-nextjs-realtime Patch
@internal/testcontainers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the audioWaveform functionality by modifying the way options are passed. The audioWaveform function now passes user-defined options (including version and checksum) to the AudioWaveformExtension constructor. The constructor stores these options, and the onBuildComplete method now retrieves version and checksum from these options before defaulting to constants.

Changes

File Change Summary
packages/build/src/extensions/audioWaveform.ts Modified the audioWaveform function to pass user-defined options to AudioWaveformExtension; updated the constructor and onBuildComplete to handle version and checksum options.
.changeset/lemon-fireants-repair.md Added a patch for the @trigger.dev/build package addressing a missing construction option in the AudioWaveformExtension.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant AWF as audioWaveform()
    participant Ext as AudioWaveformExtension

    Caller->>AWF: Call audioWaveform(options)
    AWF->>Ext: Instantiate AudioWaveformExtension(options)
    Ext->>Ext: Store options (version, checksum)
    Note over Ext: onBuildComplete uses options if provided
Loading

Suggested reviewers

  • ericallam

Poem

I'm a little rabbit, coding with delight,
Hopping through changes, options shining bright.
Carrots of version and checksum align,
In a world of code, everything feels just fine.
Celebrate this update with a joyful byte!
🐰🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb1260a and 55afe3b.

📒 Files selected for processing (1)
  • .changeset/lemon-fireants-repair.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvictor thanks, this was a glaring omission.

@matt-aitken matt-aitken merged commit 2771fd7 into triggerdotdev:main Feb 9, 2025
1 check was pending
@zvictor zvictor deleted the patch-1 branch February 9, 2025 16:20
@zvictor
Copy link
Contributor Author

zvictor commented Feb 9, 2025

@zvictor thanks, this was a glaring omission.

No worries, I was just studying the codebase for a future contribution when I noticed that!
But I am now happily part of the hall of fame ❤️

Soon I will push something a bit more impactful 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants