-
-
Notifications
You must be signed in to change notification settings - Fork 725
missing construction option in AudioWaveformExtension
#1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 55afe3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Caution Review failedThe pull request is closed. WalkthroughThe changes update the audioWaveform functionality by modifying the way options are passed. The audioWaveform function now passes user-defined options (including version and checksum) to the AudioWaveformExtension constructor. The constructor stores these options, and the onBuildComplete method now retrieves version and checksum from these options before defaulting to constants. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant AWF as audioWaveform()
participant Ext as AudioWaveformExtension
Caller->>AWF: Call audioWaveform(options)
AWF->>Ext: Instantiate AudioWaveformExtension(options)
Ext->>Ext: Store options (version, checksum)
Note over Ext: onBuildComplete uses options if provided
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zvictor thanks, this was a glaring omission.
No worries, I was just studying the codebase for a future contribution when I noticed that! Soon I will push something a bit more impactful 😊 |
Small fix for a missing argument.
✅ Checklist
It's a tiny change. I admit I have not bothered testing it.
What convention? Where is it? Couldn't find in the CONTRIBUTING.md
Summary by CodeRabbit
@trigger.dev/build
package to address a missing construction option in theAudioWaveformExtension
.