Require max duration in trigger.config. Validate TRIGGER_ACCESS_TOKEN is a PAT.

.changeset/tiny-seals-appear.md

@@ -0,0 +1,6 @@
+---
+"trigger.dev": patch
+"@trigger.dev/core": patch
+---
+
+Require maxDuration config and have a better error for bad CI tokens

packages/cli-v3/e2e/fixtures/emit-decorator-metadata/trigger.config.ts

@@ -7,4 +7,5 @@ export default defineConfig({
   build: {
     extensions: [emitDecoratorMetadata()],
   },
+  maxDuration: 3600,
 });

packages/cli-v3/e2e/fixtures/esm-only-external/trigger.config.ts

@@ -6,4 +6,5 @@ export default defineConfig({
   build: {
     external: ["mupdf"],
   },
+  maxDuration: 3600,
 });

packages/cli-v3/e2e/fixtures/hello-world/trigger.config.ts

@@ -3,4 +3,5 @@ import { defineConfig } from "@trigger.dev/sdk/v3";
 export default defineConfig({
   project: "<fixture project>",
   dirs: ["./src/trigger"],
+  maxDuration: 3600,
 });

packages/cli-v3/e2e/fixtures/monorepo-react-email/packages/trigger/trigger.config.ts

@@ -3,4 +3,5 @@ import { defineConfig } from "@trigger.dev/sdk/v3";
 export default defineConfig({
   project: "<fixture project>",
   dirs: ["./src"],
+  maxDuration: 3600,
 });

packages/cli-v3/e2e/fixtures/otel-telemetry-loader/trigger.config.ts

@@ -5,4 +5,5 @@ export default defineConfig({
   project: "<fixture project>",
   dirs: ["./src/trigger"],
   instrumentations: [new OpenAIInstrumentation()],
+  maxDuration: 3600,
 });

packages/cli-v3/src/commands/login.ts

@@ -23,6 +23,10 @@ import { spinner } from "../utilities/windows.js";
 import { isLinuxServer } from "../utilities/linux.js";
 import { VERSION } from "../version.js";
 import { env } from "std-env";
+import {
+  isPersonalAccessToken,
+  NotPersonalAccessTokenError,
+} from "../utilities/isPersonalAccessToken.js";
 
 export const LoginCommandOptions = CommonCommandOptions.extend({
   apiUrl: z.string(),
@@ -84,6 +88,12 @@ export async function login(options?: LoginOptions): Promise<LoginResult> {
       const accessTokenFromEnv = env.TRIGGER_ACCESS_TOKEN;
 
       if (accessTokenFromEnv) {
+        if (!isPersonalAccessToken(accessTokenFromEnv)) {
+          throw new NotPersonalAccessTokenError(
+            "Your TRIGGER_ACCESS_TOKEN is not a Personal Access Token, they start with 'tr_pat_'. You can generate one here: https://cloud.trigger.dev/account/tokens"
+          );
+        }
+
         const auth = {
           accessToken: accessTokenFromEnv,
           apiUrl: env.TRIGGER_API_URL ?? opts.defaultApiUrl ?? "https://api.trigger.dev",
@@ -292,6 +302,10 @@ export async function login(options?: LoginOptions): Promise<LoginResult> {
       span.end();
 
       if (options?.embedded) {
+        if (e instanceof NotPersonalAccessTokenError) {
+          throw e;
+        }
+
         return {
           ok: false as const,
           error: e instanceof Error ? e.message : String(e),

packages/cli-v3/src/config.ts

@@ -289,6 +289,12 @@ function validateConfig(config: TriggerConfig, warn = true) {
     config.build.extensions.push(adaptResolveEnvVarsToSyncEnvVarsExtension(resolveEnvVarsFn));
   }
 
+  if (!config.maxDuration) {
+    throw new Error(
+      `The "maxDuration" trigger.config option is now required, and must be at least 5 seconds.`
+    );
+  }
+
   if (config.runtime && config.runtime === "bun") {
     warn &&
       prettyWarning(

packages/cli-v3/src/utilities/isPersonalAccessToken.ts

@@ -0,0 +1,12 @@
+const tokenPrefix = "tr_pat_";
+
+export function isPersonalAccessToken(token: string) {
+  return token.startsWith(tokenPrefix);
+}
+
+export class NotPersonalAccessTokenError extends Error {
+  constructor(message: string) {
+    super(message);
+    this.name = "NotPersonalAccessTokenError";
+  }
+}

packages/cli-v3/templates/trigger.config.mjs.template

@@ -4,8 +4,10 @@ export default defineConfig({
   project: "${projectRef}",
   runtime: "${runtime}",
   logLevel: "log",
-  // Set the maxDuration to 300 seconds for all tasks. See https://trigger.dev/docs/runs/max-duration
-  // maxDuration: 300, 
+  // The max compute seconds a task is allowed to run. If the task run exceeds this duration, it will be stopped.
+  // You can override this on an individual task.
+  // See https://trigger.dev/docs/runs/max-duration
+  maxDuration: 3600,
   retries: {
     enabledInDev: true,
     default: {

packages/cli-v3/templates/trigger.config.ts.template

@@ -4,8 +4,10 @@ export default defineConfig({
   project: "${projectRef}",
   runtime: "${runtime}",
   logLevel: "log",
-  // Set the maxDuration to 300 seconds for all tasks. See https://trigger.dev/docs/runs/max-duration
-  // maxDuration: 300, 
+  // The max compute seconds a task is allowed to run. If the task run exceeds this duration, it will be stopped.
+  // You can override this on an individual task.
+  // See https://trigger.dev/docs/runs/max-duration
+  maxDuration: 3600,
   retries: {
     enabledInDev: true,
     default: {

packages/core/src/v3/config.ts

@@ -116,7 +116,7 @@ export type TriggerConfig = {
    *
    * @see https://trigger.dev/docs/tasks/overview#maxduration-option
    */
-  maxDuration?: number;
+  maxDuration: number;
 
   /**
    * Enable console logging while running the dev CLI. This will print out logs from console.log, console.warn, and console.error. By default all logs are sent to the trigger.dev backend, and not logged to the console.

references/bun-catalog/trigger.config.ts

@@ -3,6 +3,7 @@ import { defineConfig } from "@trigger.dev/sdk/v3";
 export default defineConfig({
   runtime: "bun",
   project: "proj_uxbxncnbsyamyxeqtucu",
+  maxDuration: 3600,
   machine: "small-2x",
   retries: {
     enabledInDev: true,

references/nextjs-realtime/trigger.config.ts

@@ -11,4 +11,5 @@ export default defineConfig({
   build: {
     extensions: [rscExtension({ reactDomEnvironment: "worker" })],
   },
+  maxDuration: 3600,
 });

references/v3-catalog/trigger.config.ts

@@ -17,8 +17,7 @@ export default defineConfig({
   machine: "medium-1x",
   instrumentations: [new OpenAIInstrumentation()],
   additionalFiles: ["wrangler/wrangler.toml"],
-  // Set the maxDuration to 300s for all tasks. See https://trigger.dev/docs/runs/max-duration
-  // maxDuration: 300,
+  maxDuration: 3600,
   retries: {
     enabledInDev: true,
     default: {