Skip to content

Batch Trigger upgrades #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Nov 28, 2024
Merged

Batch Trigger upgrades #1502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7ec44c2
WIP batch trigger v2
ericallam Nov 22, 2024
e9f2f8c
Fix for the DateField being one month out… getUTCMonth() is zero inde…
matt-aitken Nov 20, 2024
5ee6b8e
Added a custom date range filter
matt-aitken Nov 21, 2024
b4ed220
Deal with closing the custom date range
matt-aitken Nov 21, 2024
bd14761
Child runs filter
matt-aitken Nov 21, 2024
6097160
Fix for the clear button untoggling the child runs
matt-aitken Nov 21, 2024
4aa5845
WIP batchTriggerV2
ericallam Nov 25, 2024
d69abd1
Finished removing rate limit from the webapp
ericallam Nov 25, 2024
a664859
Added an index TaskRun to make useRealtimeBatch performant
ericallam Nov 26, 2024
a0dfd2d
Renamed the period filter labels to be “Last X mins”
matt-aitken Nov 25, 2024
daec8f4
Denormalize background worker columns into TaskRun
ericallam Nov 26, 2024
aa82f8d
Use the runTags column on TaskRun
matt-aitken Nov 25, 2024
976b275
Add TaskRun ("projectId", "id" DESC) index
matt-aitken Nov 26, 2024
1674d33
Improved the v2 batch trigger endpoint to process items in parallel a…
ericallam Nov 26, 2024
e8cfe88
Added a runId filter, and WIP for batchId filter
matt-aitken Nov 26, 2024
b0c3c41
WIP triggerAll
ericallam Nov 26, 2024
4b181fa
Add new batch methods for triggering multiple different tasks in a si…
ericallam Nov 27, 2024
fd18784
Disabled switch styling
matt-aitken Nov 26, 2024
26980f0
Batch filtering, force child runs to show if filtering by batch/run
matt-aitken Nov 26, 2024
492fb79
Added schedule ID filtering
matt-aitken Nov 26, 2024
0060a64
Force child runs to show when filtering by scheduleId, for consistency
matt-aitken Nov 26, 2024
f1919b1
realtime: allow setting enabled: false on useApiClient
ericallam Nov 27, 2024
1b34daf
Batches page
matt-aitken Nov 27, 2024
2ebc4e5
Always complete batches, not only batchTriggerAndWait in deployed tasks
ericallam Nov 27, 2024
658f400
Add batch.retrieve and allow filtering by batch in runs.list
ericallam Nov 27, 2024
ff65310
Renamed pending to “In progress”
matt-aitken Nov 27, 2024
5f5cbe2
Tidied up the table a bit
matt-aitken Nov 27, 2024
e60b75b
Deal with old batches: “Legacy batch”
matt-aitken Nov 27, 2024
eac6aa7
Added the Batch to the run inspector
matt-aitken Nov 27, 2024
4b2932a
Fixed the migration that created the new idempotency key index on Bat…
ericallam Nov 27, 2024
4070c6a
Fixed the name of the idempotencyKeyExpiresAt option and now default …
ericallam Nov 27, 2024
f97d55e
Timezone fix: wrong month in Usage page dropdown
matt-aitken Nov 27, 2024
78e3a56
The DateField now defaults to local time, but can be overriden to use…
matt-aitken Nov 27, 2024
f95569a
Don’t allow the task icon to get squished
matt-aitken Nov 27, 2024
b7599ed
BatchFilters removed unused imports
matt-aitken Nov 27, 2024
99a3137
In the batch filtering, use `id` instead of `batchId` in the URL
matt-aitken Nov 27, 2024
681e75a
BatchFilters: we don’t need a child tasks hidden input field
matt-aitken Nov 27, 2024
bc07b52
Creates some common filter components/functions
matt-aitken Nov 27, 2024
b822915
Fix for batchVersion check when filtering by batch status
matt-aitken Nov 27, 2024
4c5fd2a
Add additional logging around telemetry and more attributes for trigg…
ericallam Nov 27, 2024
fc821ad
Show clear button for specific id filters
matt-aitken Nov 27, 2024
d5c1bda
Batch list: only allow environments that are part of this project
matt-aitken Nov 27, 2024
69f3dca
Unnecessary optional chain
matt-aitken Nov 27, 2024
153af67
Add JSDocs
ericallam Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TaskRun ("projectId", "id" DESC) index
  • Loading branch information
@matt-aitken @ericallam
matt-aitken authored and ericallam committed Nov 27, 2024
commit 976b2754df185b32c71a44416826c6ede1f752cc
2 changes: 2 additions & 0 deletions ...a/migrations/20241125174424_task_run_project_id_id_desc_index_for_runs_list/migration.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- CreateIndex
CREATE INDEX CONCURRENTLY IF NOT EXISTS "TaskRun_projectId_id_idx" ON "TaskRun"("projectId", "id" DESC);
1 change: 1 addition & 0 deletions internal-packages/database/prisma/schema.prisma
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1796,6 +1796,7 @@ model TaskRun {
@@index([projectId, createdAt, taskIdentifier])
//Runs list
@@index([projectId])
@@index([projectId, id(sort: Desc)])
@@index([projectId, taskIdentifier])
@@index([projectId, status])
@@index([projectId, taskIdentifier, status])
Expand Down