Skip to content

Fix: Prevent hung worker process on flush exceptions #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fix: Prevent hung worker process on flush exceptions #1501

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d4d01c
deprecate cli logger warn and error methods
nicktrn Nov 27, 2024
1b513c3
replace broken error logger in deployed workers
nicktrn Nov 27, 2024
1e5b400
changeset
nicktrn Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace broken error logger in deployed workers
  • Loading branch information
@nicktrn
nicktrn committed Nov 27, 2024
commit 1b513c3f16b9855bb44584989a7e6e141a43c89d
4 changes: 2 additions & 2 deletions packages/cli-v3/src/executions/taskRunProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export class TaskRunProcess {
try {
await this.#flush();
} catch (err) {
logger.error("Error flushing task run process", { err });
console.error("Error flushing task run process", { err });
}

await this.kill();
Expand All @@ -94,7 +94,7 @@ export class TaskRunProcess {
try {
await this.#flush();
} catch (err) {
logger.error("Error flushing task run process", { err });
console.error("Error flushing task run process", { err });
}

if (kill) {
Expand Down