Skip to content

Fix: Handle circular references in flattenAttributes function #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Fix: Handle circular references in flattenAttributes function #1433

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6915d9e
Fix: Handle circular references in flattenAttributes function
yadavshubham01 Oct 24, 2024
f508bf5
Merge branch 'main' into Update-flattenAttributes
yadavshubham01 Oct 24, 2024
b29ba40
Update flattenAttributes.test.ts
yadavshubham01 Oct 24, 2024
e58686c
Update packages/core/src/v3/utils/flattenAttributes.ts
ericallam Oct 24, 2024
400dbb2
Update packages/core/src/v3/utils/flattenAttributes.ts
ericallam Oct 24, 2024
c908f3a
Create brown-laws-rest.md
ericallam Oct 24, 2024
cb3f598
Merge branch 'main' into Update-flattenAttributes
ericallam Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/core/src/v3/utils/flattenAttributes.ts 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
  • Loading branch information
@ericallam @coderabbitai
ericallam and coderabbitai[bot] authored Oct 24, 2024
commit e58686cd0774d800998a086b5046060350d0596e
2 changes: 1 addition & 1 deletion packages/core/src/v3/utils/flattenAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function flattenAttributes(
}

// Check for circular reference
if (typeof obj === "object" && seen.has(obj)) {
if (obj !== null && typeof obj === "object" && seen.has(obj)) {
result[prefix || ""] = CIRCULAR_REFERENCE_SENTINEL;
return result;
}
Expand Down
Loading