Skip to content

Commit 3c7056a

Browse files
carderneTrigger.dev RepoOps
authored andcommitted
chore: move vouch requests to GitHub Discussions
## Summary Move vouch requests from issues to comments in the [vouch discussion](#5010). Align the contributing guidelines with the discussion: external changes require security review and verification, vouch requests are extremely unlikely to be accepted unless the team already knows the contributor, and approval allows draft PR submissions without guaranteeing acceptance. Encourage bug reports and feature requests with good reproductions and suggested fixes. Maintainers continue approving contributors by manually editing the vouched contributors list. Remove the issue request form and issue-comment approval automation, and link directly to the discussion from the contributing guidelines and issue chooser. PR trust checks remain unchanged. Mono-RevId: cfcb06236ab9ccb3442d4badd68ba6704523ccdc
1 parent df134f7 commit 3c7056a

5 files changed

Lines changed: 18 additions & 57 deletions

File tree

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ body:
3232
description: Describe how to reproduce your bug. Steps, code snippets, reproduction repos etc.
3333
validations:
3434
required: true
35+
- type: textarea
36+
attributes:
37+
label: Suggested fix
38+
description: If you have an idea for a fix, describe the approach or architecture here.
39+
validations:
40+
required: false
3541
- type: textarea
3642
attributes:
3743
label: Additional information

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
blank_issues_enabled: true
22
contact_links:
3+
- name: Request a vouch
4+
url: https://github.com/triggerdotdev/trigger.dev/discussions/5010
5+
about: Request a vouch by leaving a comment in this discussion before opening your first PR
36
- name: Ask a Question
47
url: https://trigger.dev/discord
58
about: Ask questions and discuss with other community members

‎.github/ISSUE_TEMPLATE/vouch-request.yml‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎.github/workflows/vouch-manage-by-issue.yml‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎CONTRIBUTING.md‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,18 @@ Thank you for helping us make Trigger.dev even better! 🤩
1212

1313
We use [vouch](https://github.com/mitchellh/vouch) to manage contributor trust. **PRs from unvouched users are automatically closed.**
1414

15+
> **Important:** Because Trigger.dev is production infrastructure, every external change needs a security review and verification by our team. Your vouch request is _extremely_ unlikely to be accepted unless you are already known to the Trigger.dev team in some way, either as a customer or self-hoster or some other reason we'd be familiar with your work.
16+
17+
We really appreciate bug reports or feature requests. A good reproduction always gets fixed faster than a PR would get merged. You can even suggest the architecture of the fix in the bug report under "Suggested fix".
18+
1519
Before you open your first pull request, you need to be vouched by a maintainer. Here's how:
1620

17-
1. Open a [Vouch Request](https://github.com/triggerdotdev/trigger.dev/issues/new?template=vouch-request.yml) issue.
18-
2. Tell us what you'd like to work on and share any relevant background.
19-
3. A maintainer will review your request and vouch for you by commenting on the issue.
20-
4. Once vouched, your PRs will be accepted normally.
21+
1. Leave a comment in [Vouch please: how to become a contributor](https://github.com/triggerdotdev/trigger.dev/discussions/5010). Please don't open a separate issue or discussion to request a vouch.
22+
2. Tell us what you'd like to work on, with a link to the issue if there is one. Include a little about your background, with links to relevant projects or previous contributions if available.
23+
3. A maintainer will review your request and let you know once you've been added to the vouched contributors list.
24+
4. Once approved, follow the guidelines below and open your PR as a draft first.
2125

22-
If you're unsure whether you're already vouched, go ahead and open a PR — the check will tell you.
26+
Being vouched lets you submit PRs; it does not guarantee that a particular change will be accepted.
2327

2428
## Developing
2529

0 commit comments

Comments
 (0)