Skip to content

Commit df134f7

Browse files
MariefayTrigger.dev RepoOps
authored andcommitted
feat(webapp): one trace status and a full-width toolbar on the run page
The run page now shows one clear trace status next to Cancel and Replay: whether the run is live, still loading, only partially shown, or failed to load (with a retry). Search, filters and the run actions share a single full-width toolbar, and a finished run no longer shows a spinner on its root while its trace loads. Mono-RevId: f853bcf7d20db0250625163bfb0936c72c5cb823
1 parent 688c2e7 commit df134f7

8 files changed

Lines changed: 710 additions & 214 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
area: webapp
3+
type: improvement
4+
---
5+
6+
The run page shows one clear trace status next to Cancel and Replay: whether the run is live, still loading, only partially shown, or failed to load (with a retry). Search, filters and the run actions now share a single full-width toolbar.

‎apps/webapp/app/hooks/useProgressiveTrace.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ export type ProgressiveTraceState = {
8080
linkedRunIdBySpanId: Record<string, string>;
8181
isComplete: boolean;
8282
isTruncated: boolean;
83-
// Errors-only matches were capped; separate from `isTruncated`, which stops live reload.
84-
errorsTruncated: boolean;
8583
loadFailed: boolean;
8684
};
8785

@@ -99,7 +97,6 @@ function initialState(trace: ProgressiveTraceInput): ProgressiveTraceState {
9997
linkedRunIdBySpanId: trace.linkedRunIdBySpanId ?? {},
10098
isComplete: !trace.progressive?.hasMore,
10199
isTruncated: false,
102-
errorsTruncated: false,
103100
loadFailed: false,
104101
};
105102
}
@@ -226,7 +223,6 @@ export function useProgressiveTrace(
226223
linkedRunIdBySpanId: view.linkedRunIdBySpanId,
227224
isComplete: prev.isComplete,
228225
isTruncated: prev.isTruncated,
229-
errorsTruncated: prev.errorsTruncated,
230226
loadFailed: prev.loadFailed,
231227
}));
232228
}, []);
@@ -385,9 +381,6 @@ export function useProgressiveTrace(
385381
errorsFetchedRef.current = true;
386382
assembler.mergeChunk(data.events.map(toChunkEvent), { source: "errors" });
387383
rebuild(meta, assembler);
388-
if (data.isTruncated) {
389-
setState((prev) => (prev.errorsTruncated ? prev : { ...prev, errorsTruncated: true }));
390-
}
391384
})();
392385

393386
return () => {

0 commit comments

Comments
 (0)