Add Linux-specific gzopen options and more tests #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
My new test cases try to create temp files and directories, and the wasm32 run is failing with: |
folkertdev
reviewed
Apr 2, 2025
Member
folkertdev
left a comment
folkertdev
left a comment
There was a problem hiding this comment.
I got wasm to work for the tests. You need to make tempfile not use that std::env::temp_dir function
Comment on lines
+68
to
+69
| let temp_dir = tempfile::TempDir::new_in(temp_dir_path).unwrap(); | ||
| let temp_path = temp_dir.path(); |
Member
There was a problem hiding this comment.
so yeah we'll have to use TempDir::new_in instead of TempDir::new throughout. We can probably extract this logic into a function when we add more tests.
folkertdev
reviewed
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.