Skip to content

Store mode on the stack in dispatch #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Store mode on the stack in dispatch #304

merged 2 commits into from
Feb 25, 2025

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Feb 25, 2025

This improves performance for chunk size 2^4 by a couple percent.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zlib-rs/src/inflate.rs 87.87% 8 Missing ⚠️
Files with missing lines Coverage Δ
zlib-rs/src/inflate.rs 91.20% <87.87%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@bjorn3
Copy link
Collaborator Author

bjorn3 commented Feb 25, 2025

@bjorn3
Copy link
Collaborator Author

bjorn3 commented Feb 25, 2025

I had to do this rewrite while experimenting with adding #[loop_match] in zlib-rs. I noticed that even before I started using #[loop_match] this improved performance.

@bjorn3 bjorn3 requested a review from folkertdev February 25, 2025 15:22
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the comment

@folkertdev folkertdev merged commit aee1503 into main Feb 25, 2025
20 checks passed
@folkertdev folkertdev deleted the dispatch_local_mode branch February 25, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants