fix: malicious or compromised PAM module can DOS sudo-rs via num_msg=-1 #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the problem by throwing an error if the number is negative or unexpected, added a test too.
squell
added
C-pam
squell
reviewed
Nov 18, 2025
| } | ||
|
|
||
| #[test] | ||
| fn conversation_rejects_negative_message_count() { |
Member
There was a problem hiding this comment.
If this test is prefix with miri_, it will also be run in the Miri test (I think that is possible and useful here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem by throwing an error if the number is negative or unexpected, added a test too. This is a suggestion only.
Thread: #1311