use uninitialized output buffers for the fuzzers #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bjorn3
reviewed
Jun 10, 2025
| unsafe { output.set_len(usize::try_from(total).unwrap()) }; | ||
|
|
||
| // Just check that this byte is in fact initialized. | ||
| _ = output.last() == Some(&0); |
There was a problem hiding this comment.
Suggested change
| _ = output.last() == Some(&0); | |
| std::hint::black_box(output.last() == Some(&0)); |
otherwise it will be optimized away, which would probably cause asan to not catch uninitialized memory.
bjorn3
reviewed
Jun 10, 2025
| unsafe { output.set_len(usize::try_from(total).unwrap()) }; | ||
|
|
||
| // Just check that this byte is in fact initialized. | ||
| _ = output.last() == Some(&0); |
bjorn3
approved these changes
Jun 10, 2025
we previously missed a bug in zlib-rs due to only using initialized output buffers
folkertdev
force-pushed
the
fuzz-output-uninitialized
branch
from
03e5689 to
f6c91a5
Compare
|
Just as a note: currently the fuzzer probably won't catch uninitialized memory. For that, we'd need 1) a much more recent version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we previously missed a bug in zlib-rs due to only using initialized output buffers. Now we use initialized buffers at least in some places. Because bzip2 doesn't use SIMD, it should never read from these buffers anyway. In effect we test now that the total number of bytes that was written is actually correct.
cc @ros-cr