Add MaybeUninit<u8> (de)compress API
#147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a safe API for `MaybeUninit<u8>` would be necessary for async-compression to wrap and reduce the performance penalty of initializing the buffer for all `tokio::io::*` traits implementation
bjorn3
reviewed
Sep 27, 2025
|
Simplified the API of |
This was referenced Sep 27, 2025
bjorn3
approved these changes
Oct 8, 2025
|
Would squash it this evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a safe API for
MaybeUninit<u8>would be necessary for async-compression to wrap and reduce the performance penalty of initializing the buffer for alltokio::io::*traits implementation.Also update
(de)compress_vecAPI to use the new API instead of passing a&mut [u8]which technically violates rust's semantics.