test: add Github actions tests, fix non-compiling code #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @willpoint @trietmn |
odeke-em
force-pushed
the
github-add-actions-tests
branch
from
34886ed to
70e6315
Compare
This change adds Github actions that'll run on every pull request, push to main. This will help curb the case in which we have non-compiling code or code that fails to pass tests. Also while here fixed the non-compiling code with the intention of a replacement that wasn't fully implemented in PR trietmn#3 Updates trietmn#5
odeke-em
force-pushed
the
github-add-actions-tests
branch
from
70e6315 to
1d76a66
Compare
odeke-em
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Github actions that'll run
on every pull request, push to main. This will help
curb the case in which we have non-compiling code or
code that fails to pass tests.
Also while here fixed the non-compiling code with the intention
of a replacement that wasn't fully implemented in PR #3
Updates #5