Skip to content

Commit

Permalink
Blimp: stop libraries including AP_Logger.h in .h files
Browse files Browse the repository at this point in the history
AP_Logger.h is a nexus of includes; while this is being improved over
time, there's no reason for the library headers to include AP_Logger.h
as the logger itself is access by singleton and the structures are in
LogStructure.h

This necessitated moving The PID_Info structure out of AP_Logger's
namespace.  This cleans up a pretty nasty bit - that structure is
definitely not simply used for logging, but also used to pass pid
information around to controllers!

There are a lot of patches in here because AP_Logger.h, acting as a
nexus, was providing transitive header file inclusion in many (some
unlikely!) places.
  • Loading branch information
peterbarker committed Apr 8, 2022
1 parent 42383dd commit c7f954c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Blimp/GCS_Mavlink.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ void GCS_MAVLINK_Blimp::send_pid_tuning()
if (!HAVE_PAYLOAD_SPACE(chan, PID_TUNING)) {
return;
}
const AP_Logger::PID_Info *pid_info = nullptr;
const AP_PIDInfo *pid_info = nullptr;
switch (axes[i]) {
case PID_SEND::VELX:
pid_info = &blimp.pid_vel_xy.get_pid_info_x();
Expand Down

0 comments on commit c7f954c

Please sign in to comment.