Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [v2] add new chart #26

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

crandles
Copy link
Contributor

@crandles crandles commented Mar 28, 2025

Revamped chart & chart release workflow.

You can try the chart I published in my own ghcr namespace:

helm install trickster oci://ghcr.io/crandles/charts/trickster-v2

Note: last published under trickster-v2 name.

or to setup and install via kind:

TRICKSTER_ORG=crandles make setup-kind install query

Notes:

  • Retooled chart around a single associated persistentVolume
  • Very limited config objects are modified by the chart (ports, default paths); but they can all be overriden
  • Allow for override labels/annotations of every resource
  • Tested locally: with prometheus backend, default cache, with a pvc, with ingress, with nodeport
  • Updated Readme
  • Added release workflow & tested via fork

To Do:

  • Allow label/annotation overrides, per-object
  • test locally (deferring testing via workflow to another PR)
    • pvc
    • ingress
    • nodeport
    • local prometheus target
  • review trickster configs closer; looking for values that need special attention in helm template
    • configure caches to use PVC/emptyDir storage path
    • set server/metrics listen port via service.* values
  • allow override of ENV vars & CLI Flags

Part of #24 / #25

Resolves #28

@crandles crandles force-pushed the new-chart branch 2 times, most recently from f59bd93 to 579117b Compare March 28, 2025 23:53
@crandles crandles marked this pull request as ready for review March 28, 2025 23:57
@crandles crandles requested a review from jranson March 28, 2025 23:57
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles force-pushed the new-chart branch 2 times, most recently from 1c07966 to b43743f Compare March 30, 2025 20:08
Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles merged commit 4ddf880 into trickstercache:main Mar 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chart release workflow
2 participants