run.c: Fix uninitialized field #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fd` field in the `Transformer` structure is not initialized. Because of that, on certain code paths, calls to the system functions will use a wrong file descriptor. This causes an assertion failure in Unikraft. Workaround for this was the commenting out of the `CONFIG_LIBUKDEBUG_ENABLE_ASSERT` configuration option in Unikraft. Fix this by initializing `fd` to -1. This makes the current code fully functional on Unikraft, eliminating the assertion failure. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
trholding
approved these changes
Oct 9, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fdfield in theTransformerstructure is not initialized. Because of that, on certain code paths, calls to the system functions will use a wrong file descriptor. This causes an assertion failure in Unikraft.Workaround for this was the commenting out of the
CONFIG_LIBUKDEBUG_ENABLE_ASSERTconfiguration option in Unikraft.Fix this by initializing
fdto -1. This makes the current code fully functional on Unikraft, eliminating the assertion failure.