Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

Chore - Add next 12 as peer dependency#45

Merged
trezy merged 1 commit intotrezy:mainfrom
kiily:chore/next-js-12
Dec 4, 2022
Merged

Chore - Add next 12 as peer dependency#45
trezy merged 1 commit intotrezy:mainfrom
kiily:chore/next-js-12

Conversation

@kiily
Copy link
Copy Markdown
Contributor

@kiily kiily commented Aug 12, 2022

Addressing the bug described in this issue: #39.

This should require no changes to how the module works but will simply allow it to be installed for users already on Next.js 12.

Let me know if this makes sense or whether a more in-depth explanation is needed🙏

@kiily
Copy link
Copy Markdown
Contributor Author

kiily commented Sep 13, 2022

Is there an update on when this would be merged or any further feedback? Let me know 🙏

@kiily
Copy link
Copy Markdown
Contributor Author

kiily commented Oct 18, 2022

Just a nudge on this one, we'd like to use next-safe in our project and this is the last remaining blocker

@I-keep-trying
Copy link
Copy Markdown

Is this going to work for Next13?

@kiily
Copy link
Copy Markdown
Contributor Author

kiily commented Nov 16, 2022

You're quite right! It will not... In principle, the code should work correctly in Next.js 13 but you won't be able to install it properly unless it is added here as a peer dependency 😢

Copy link
Copy Markdown
Owner

@trezy trezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch... I've deffo fallen behind here. I'll make sure to add Next 13 ASAP, as well.

@trezy trezy merged commit 79c6a2a into trezy:main Dec 4, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2022

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants