-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elements: derive confidential addresses using SLIP-0077 #474
base: main
Are you sure you want to change the base?
Conversation
Please let me know if I should "wrap" the Elements-related parts with |
Yes, please |
6878d72
to
30b4c3f
Compare
Tested on bitcoin-only firmware with:
and on altcoin-enabled firmware:
|
30b4c3f
to
da7eea9
Compare
da7eea9
to
1e9563b
Compare
Rebased (to resolve a conflict) and force-pushed 1e9563b. |
perhaps this should be deferred until #617 ? OTOH this seems to only affect GetAddress, in which case maybe that's not necessary? |
Indeed, currently it affects only GetAddress (for deriving the blinding public key). In future PR (after #617), we will add support for unblinding confidential UTXOs (during transaction signing) and it will use SLIP-0077 to derive the corresponding blinding private key. |
1e9563b
to
03a5932
Compare
03a5932
to
682bdad
Compare
Rebased over the latest |
Following trezor#66 and trezor#398, it would allow receiving confidential transactions to addresses generated on the devices. Blinding, unblinding and signing will be added in separate PRs.
682bdad
to
560fb49
Compare
Hi there, thank you for your PR. Same as with #473 we are interested in adding this to our firmware but we just don't have enough capacity to review it right now. We would be more than happy to take a closer look at it later, when our capacity frees up a little, likely during the course of 2021. Thank you for your understanding. |
Following #66 and #398, it would allow receiving confidential
transactions to addresses generated on the devices.
Blinding, unblinding and signing will be added in separate PRs.