Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements: derive confidential addresses using SLIP-0077 #474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 31, 2019

Following #66 and #398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.

@romanz
Copy link
Contributor Author

romanz commented Aug 31, 2019

Please let me know if I should "wrap" the Elements-related parts with if not utils.BITCOIN_ONLY.

@prusnak
Copy link
Member

prusnak commented Aug 31, 2019

Yes, please

@romanz
Copy link
Contributor Author

romanz commented Sep 1, 2019

Tested on bitcoin-only firmware with:

$ BITCOIN_ONLY=1 make -C core clean build_unix
$ py.test tests/device_tests/ -k 'getaddress and not altcoin'

and on altcoin-enabled firmware:

$ BITCOIN_ONLY=0 make -C core clean build_unix
$ py.test tests/device_tests/ -k 'getaddress'

@romanz
Copy link
Contributor Author

romanz commented Nov 6, 2019

Rebased (to resolve a conflict) and force-pushed 1e9563b.
Please let me know if there is anything else that I can help with :)

@prusnak prusnak added the feature Product related issue visible for end user label Nov 9, 2019
@prusnak prusnak added this to the backlog milestone Nov 10, 2019
@matejcik
Copy link
Contributor

perhaps this should be deferred until #617 ? OTOH this seems to only affect GetAddress, in which case maybe that's not necessary?

@romanz
Copy link
Contributor Author

romanz commented Nov 20, 2019

OTOH this seems to only affect GetAddress, in which case maybe that's not necessary?

Indeed, currently it affects only GetAddress (for deriving the blinding public key).

In future PR (after #617), we will add support for unblinding confidential UTXOs (during transaction signing) and it will use SLIP-0077 to derive the corresponding blinding private key.

@romanz
Copy link
Contributor Author

romanz commented Jan 18, 2020

Rebased over the latest master.

Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
@prusnak prusnak added the altcoin Any non-Bitcoin coins label Aug 3, 2020
@tsusanka tsusanka added the liquid label Aug 3, 2020
@tsusanka
Copy link
Contributor

tsusanka commented Aug 4, 2020

Hi there, thank you for your PR. Same as with #473 we are interested in adding this to our firmware but we just don't have enough capacity to review it right now. We would be more than happy to take a closer look at it later, when our capacity frees up a little, likely during the course of 2021. Thank you for your understanding.

@tsusanka tsusanka removed the feature Product related issue visible for end user label Aug 4, 2020
@romanz romanz requested a review from tsusanka as a code owner March 27, 2021 08:23
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@tsusanka tsusanka removed the liquid label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoin Any non-Bitcoin coins
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

4 participants