-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layouts: altcoin apps #1538
layouts: altcoin apps #1538
Conversation
82b6905
to
3b4eea1
Compare
ab8c4c8
to
f20861c
Compare
Rebased to master. UI diff. |
6dcb057
to
a595b02
Compare
before this is merged, I want to do two things:
|
a595b02
to
2330358
Compare
Progress popups are not ported yet as they're unlike anything else. Introduces paginate_paragraphs.
2330358
to
5f0788d
Compare
Thanks for finishing confirm_properties, it looks very good! Seems like device tests failed, probably due to the ButtonRequest changes. Am curious about the final UI diff, but the screens I've seen look OK. |
CI passing now |
Reviewed UI diff for the last time and found no regressions, only improvements. Let's merge it. |
55b3a8e
to
15bd6e2
Compare
QA OK
Wallets: |
This is a follow-up of #1480 which modifies all altcoin apps to use the layout abstraction. To support various multiple page confirms it adds the
paginate_paragraphs
function which is a generalization ofpaginate_text
that allows mixing fonts in the paginated output, with the restriction that different font text must start on a new line.In the previous PR we discussed the
truncate=
parameter which is used here to emulate the old behavior wrt. text that doesn't fit on a single screen. It's used quite a lot to keep the UI diff small (or skip the pagination logic if we know the text fits), even in some cases where pagination might be desirable. Ideas?My aim was to keep the UI diff reasonably small even though there are some differences especially for Eos and Monero.
Not covered in this PR, to be done in the next (final) one:
apps.management
andapps.webauthn
trezor.ui.layouts.tt
to multiple modules to make it smallerbr_type
values to have them consistent & useful to Suite