-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolock delay setting: raise error when out of range #1119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Untested ACK for Core with minor suggestions.
Untested LGTM for Legacy, but could use some further review.
UI changes look correct as well: https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/649243342/artifacts/master_diff/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK on the legacy part, @prusnak needs to review that in more detail
i have some comments about the rest
Hm, I don't see it as that much of a different case, but I don't really care :). Let's see if @mmilata if Gitlab passes, please autosquash and force push. |
500c092
to
75fb3e1
Compare
Fixes #1093. The confirmation screen was changed to show the value in more human-readable units.