Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolock delay setting: raise error when out of range #1119

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 21, 2020

Fixes #1093. The confirmation screen was changed to show the value in more human-readable units.

Copy link
Contributor

@tsusanka tsusanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Untested ACK for Core with minor suggestions.
Untested LGTM for Legacy, but could use some further review.

core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
@tsusanka
Copy link
Contributor

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK on the legacy part, @prusnak needs to review that in more detail

i have some comments about the rest

core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
tests/device_tests/test_autolock.py Outdated Show resolved Hide resolved
tests/device_tests/test_autolock.py Outdated Show resolved Hide resolved
@prusnak prusnak added this to the 2020-08 milestone Jul 22, 2020
@tsusanka
Copy link
Contributor

Hm, I don't see it as that much of a different case, but I don't really care :). Let's see if black solves it for us at some point in future :).

@mmilata if Gitlab passes, please autosquash and force push.

@mmilata mmilata force-pushed the mmilata/autolock-delay-limit branch from 500c092 to 75fb3e1 Compare July 22, 2020 13:04
@tsusanka tsusanka merged commit 48e1dc9 into master Jul 22, 2020
@tsusanka tsusanka deleted the mmilata/autolock-delay-limit branch July 22, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit autolock delay setting - raise error if out of range
4 participants