-
-
Notifications
You must be signed in to change notification settings - Fork 50
chore: reimplement Python script for copying artifacts #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pushed 663bbca to handle T1B1 JSONs correctly (since they don't have |
obrusvit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, we don't touch the "big" releases.json at the moment, right?
Correct - following this PR, CC: @karliatto |
|
It seems that some of this repository automation works only with |
|
It is also used by some scripts at https://github.com/trezor/trezor-firmware: |
Yes, we do not use |
|
Let's keep the |
shell.nix
Outdated
| git | ||
| python39 | ||
| nodePackages.prettier | ||
| python313Packages.click |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| python313Packages.click | |
| python3Packages.click |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might even go as far as (python3.withPackages (p: [ p.click ])) but it can wait until we need second dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3556279, thanks :)
|
Rebasing over |
77043b3 to
9600731
Compare
mmilata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Tested by reproducing the last two releases using: |
3556279 to
cdf7cf9
Compare
Following #152.
Can be tested with 2.9.1 release by running:
Also removed the old script and
pyproject.toml(since dependencies can be installed via Nix).